|
|
[merge 3005-dev] Revert of Convert MediaRouter mojom apis to intake url::Origin objects instead of strings (patchset #16 id:300001 of https://codereview.chromium.org/2627463003/ )
Reason for revert:
Compilation failure on Google Chrome Mac.
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/18243
Original issue's description:
> Convert MediaRouter mojom apis to intake url::Origin objects instead of strings
>
> Currently, MediaRouter passes origins around as strings in the mojom api, and as GURLs at a higher level. This CL changes both the strings and the GURLs to be url::Origins instead.
>
> BUG= 629374
>
> Review-Url: https://codereview.chromium.org/2627463003
> Cr-Original-Commit-Position: refs/heads/master@{#446868}
> Committed: https://chromium.googlesource.com/chromium/src/+/588ccce1960c1ca47d65c75f5edb34e5e17d6deb
> Review-Url: https://codereview.chromium.org/2627463003
> Cr-Commit-Position: refs/heads/master@{#448492}
> Committed: https://chromium.googlesource.com/chromium/src/+/441f2c5583174d5411ced1d308007b34a055a4fb
TBR=mfoltz@chromium.org,benwells@chromium.org,dcheng@chromium.org,imcheng@chromium.org,jdufault@chromium.org,sky@chromium.org,wez@chromium.org,steimel@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 629374, 689303
Review-Url: https://codereview.chromium.org/2678123003
Cr-Commit-Position: refs/heads/master@{#448508}
(cherry picked from commit 35b4a8553a6b68f24297006c39168f5ff4aa0468)
Review-Url: https://codereview.chromium.org/2678273002 .
Cr-Commit-Position: refs/branch-heads/3005@{#2}
Cr-Branched-From: 75481c5507579245a81f8b75298a17a269fce1fa-refs/heads/master@{#448507}
Committed: https://chromium.googlesource.com/chromium/src/+/03114996f3e50115f2ac72ef27a79836f715ae40
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+320 lines, -344 lines) |
Patch |
 |
M |
chrome/browser/media/android/router/media_router_android.h
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/media/android/router/media_router_android.cc
|
View
|
|
7 chunks |
+23 lines, -9 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/media/android/router/media_router_dialog_controller_android.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/media/router/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/media/router/create_presentation_connection_request.h
|
View
|
|
2 chunks |
+4 lines, -7 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/media/router/create_presentation_connection_request.cc
|
View
|
|
2 chunks |
+3 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/media/router/create_presentation_connection_request_unittest.cc
|
View
|
|
3 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/media/router/media_router.h
|
View
|
|
4 chunks |
+3 lines, -7 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/media/router/media_router_dialog_controller_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/media/router/media_sinks_observer.h
|
View
|
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/media/router/media_sinks_observer.cc
|
View
|
|
2 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/media/router/media_sinks_observer_unittest.cc
|
View
|
|
2 chunks |
+5 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/media/router/mock_media_router.h
|
View
|
|
4 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/media/router/mojo/media_router.mojom
|
View
|
|
5 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/media/router/mojo/media_router_mojo_impl.h
|
View
|
|
6 chunks |
+8 lines, -8 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/media/router/mojo/media_router_mojo_impl.cc
|
View
|
|
10 chunks |
+61 lines, -19 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
|
View
|
|
27 chunks |
+68 lines, -87 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/media/router/mojo/media_router_mojo_test.h
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/media/router/presentation_media_sinks_observer.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/media/router/presentation_media_sinks_observer.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc
|
View
|
|
2 chunks |
+1 line, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/media/router/presentation_request.h
|
View
|
|
4 chunks |
+7 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/media/router/presentation_request.cc
|
View
|
|
2 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/media/router/presentation_request_unittest.cc
|
View
|
|
2 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/media/router/presentation_service_delegate_impl.cc
|
View
|
|
5 chunks |
+12 lines, -11 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
|
View
|
|
5 chunks |
+6 lines, -7 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/media/router/test_helper.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/media/router/test_helper.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/ash/cast_config_client_media_router.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
|
View
|
|
2 chunks |
+5 lines, -7 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/media_router/media_router_ui.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/media_router/media_router_ui.cc
|
View
|
|
8 chunks |
+10 lines, -11 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
|
View
|
|
8 chunks |
+10 lines, -12 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/media_router/query_result_manager.h
|
View
|
|
4 chunks |
+4 lines, -6 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/media_router/query_result_manager.cc
|
View
|
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/media_router/query_result_manager_unittest.cc
|
View
|
|
15 chunks |
+24 lines, -23 lines |
0 comments
|
Download
|
 |
M |
chrome/test/media_router/media_router_e2e_browsertest.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/test/media_router/media_router_e2e_browsertest.cc
|
View
|
|
5 chunks |
+7 lines, -6 lines |
0 comments
|
Download
|
 |
M |
chrome/test/media_router/test_media_sinks_observer.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/test/media_router/test_media_sinks_observer.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
extensions/renderer/dispatcher.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
extensions/renderer/resources/extensions_renderer_resources.grd
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
extensions/renderer/resources/media_router_bindings.js
|
View
|
|
9 chunks |
+8 lines, -47 lines |
0 comments
|
Download
|
Total messages: 3 (2 generated)
|