Issue 2678263003: Pass notification deadline timestamp as a jlong

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2678263003: Pass notification deadline timestamp as a jlong (Closed)

Created:
3 years, 10 months ago by sfiera

Modified:
3 years, 10 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

More Reviews

Description

Pass notification deadline timestamp as a jlong Java timestamps are jlongs (int64_t) and passing a jint (int32_t) truncates them to late January, 1970 at the latest. In particular, use jlong's max value to indicate "no deadline". BUG=689022 Review-Url: https://codereview.chromium.org/2678813002 Cr-Commit-Position: refs/heads/master@{#448285} (cherry picked from commit 68c2b21598d1ffb959056909f6b4fa8bf7a17155)

Patch Set 1 #

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/android/ntp/content_suggestions_notification_helper.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download