Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2678263002: Plumb border radius through when computing clip visual rects. (Closed)

Created:
3 years, 10 months ago by chrishtr
Modified:
3 years, 10 months ago
Reviewers:
pdr., Xianzhu
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plumb border radius through when computing clip visual rects. These are used by PaintLayerClipper to notify PaintLayerPainter of the need to apply border-radius clipping masks. BUG=683733 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2678263002 Cr-Commit-Position: refs/heads/master@{#448675} Committed: https://chromium.googlesource.com/chromium/src/+/2495a581e31b2b7344b240a0a35cbae1f0be2799

Patch Set 1 #

Patch Set 2 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -110 lines) Patch
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp View 3 chunks +28 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp View 1 chunk +64 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp View 1 chunk +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp View 2 chunks +11 lines, -7 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/paint/FloatClipRect.h View 1 1 chunk +37 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h View 7 chunks +10 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp View 7 chunks +23 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTest.cpp View 24 chunks +89 lines, -36 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
chrishtr
3 years, 10 months ago (2017-02-07 05:06:00 UTC) #5
Xianzhu
lgtm
3 years, 10 months ago (2017-02-07 16:39:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678263002/20001
3 years, 10 months ago (2017-02-07 18:24:42 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 18:31:08 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2495a581e31b2b7344b240a0a35c...

Powered by Google App Engine
This is Rietveld 408576698