third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeWrapper.js - Issue 2678233002: DevTools: track more elements panel user actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeWrapper.js

Issue 2678233002: DevTools: track more elements panel user actions (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js ('K') | « third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js ('k') | third_party/WebKit/Source/devtools/front_end/host/UserMetrics.js » ('j') | third_party/WebKit/Source/devtools/front_end/host/UserMetrics.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeWrapper.js

diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeWrapper.js b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeWrapper.js

index 0c986301819d394148919759d80983537a6afdb1..7c5065b6b4a0c87e6d199f93ee0fbe7d8e8722de 100644

--- a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeWrapper.js

+++ b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeWrapper.js

@@ -22,6 +22,10 @@ Emulation.DeviceModeWrapper = class extends UI.VBox {

_toggleDeviceMode() {

this._showDeviceModeSetting.set(!this._showDeviceModeSetting.get());

+ if (this._showDeviceModeSetting.get())

+ Host.userMetrics.actionTaken(Host.UserMetrics.Action.DeviceModeToggleOn);

pfeldman 2017/02/07 19:15:27 Wait, we had that, where did it go?

+ else

+ Host.userMetrics.actionTaken(Host.UserMetrics.Action.DeviceModeToggleOff);

}

/**