third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js - Issue 2678233002: DevTools: track more elements panel user actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js

Issue 2678233002: DevTools: track more elements panel user actions (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js ('K') | « third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js ('k') | third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeWrapper.js » ('j') | third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeWrapper.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js b/third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js

index 7f49d4ddea7f7305521cade4af07691be42ef68f..c052815539ba432382ae07eac19a4264c5fcc0f5 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js

@@ -119,6 +119,10 @@ Elements.InspectElementModeController.ToggleSearchActionDelegate = class {

if (!Elements.inspectElementModeController)

return false;

Elements.inspectElementModeController._toggleInspectMode();

+ if (Elements.inspectElementModeController.isInInspectElementMode())

+ Host.userMetrics.actionTaken(Host.UserMetrics.Action.InspectElementModeToggleOn);

pfeldman 2017/02/07 19:15:27 Are we after certain actionability here?

+ else

+ Host.userMetrics.actionTaken(Host.UserMetrics.Action.InspectElementModeToggleOff);

return true;

}

};