Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 2678213002: Update touch calibration strings (Closed)

Created:
3 years, 10 months ago by malaykeshav
Modified:
3 years, 10 months ago
Reviewers:
stevenjb, oshima
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update touch calibration strings Updates the touch calibration UI strings BUG=688882 COMPONENT=Settings Strings, UI strings, Touch Calibration Review-Url: https://codereview.chromium.org/2678213002 Cr-Commit-Position: refs/heads/master@{#448699} Committed: https://chromium.googlesource.com/chromium/src/+/2fb51921aaa9c523acaa4dd83c312677d7af0f12

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/strings/ui_strings.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
malaykeshav
PTAL Updates touch calibration strings.
3 years, 10 months ago (2017-02-07 00:52:47 UTC) #2
oshima
lgtm
3 years, 10 months ago (2017-02-07 03:10:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678213002/1
3 years, 10 months ago (2017-02-07 03:52:47 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/358168)
3 years, 10 months ago (2017-02-07 03:59:57 UTC) #11
malaykeshav
Adding stevenjb@ for c/a/settings_strings.grdp
3 years, 10 months ago (2017-02-07 18:35:44 UTC) #13
stevenjb
lgtm
3 years, 10 months ago (2017-02-07 19:21:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678213002/1
3 years, 10 months ago (2017-02-07 19:35:02 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 19:42:21 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2fb51921aaa9c523acaa4dd83c31...

Powered by Google App Engine
This is Rietveld 408576698