Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 2678183002: DevTools: Always have some content in a TextPrompt (Closed)

Created:
3 years, 10 months ago by einbinder
Modified:
3 years, 10 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Always have some content in a TextPrompt If the TextPrompt was empty, it migh t have a different height then when the first character is typed. This patch adds a psuedoelement with a single character so that the height remains constant. BUG=686876 Review-Url: https://codereview.chromium.org/2678183002 Cr-Commit-Position: refs/heads/master@{#448456} Committed: https://chromium.googlesource.com/chromium/src/+/fe93dfadae6424df9875c7e9f72b27985ba7d6d1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/textPrompt.css View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
einbinder
ptal
3 years, 10 months ago (2017-02-06 21:31:33 UTC) #2
pfeldman
lgtm
3 years, 10 months ago (2017-02-06 21:38:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678183002/1
3 years, 10 months ago (2017-02-06 21:46:37 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 00:11:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fe93dfadae6424df9875c7e9f72b...

Powered by Google App Engine
This is Rietveld 408576698