[inspector] introduced debug::GeneratorObject

[inspector] introduced debug::GeneratorObject

- removed getGeneratorObjectLocation from debugger-script.js,
- one more step to remove all debugger context usages in inspector.

BUG=v8:5510
R=yangguo@chromium.org,jgruber@chromium.org,alph@chromium.org

Review-Url: https://codereview.chromium.org/2678143002
Cr-Commit-Position: refs/heads/master@{#43018}
Committed: https://chromium.googlesource.com/v8/v8/+/5870529de557db3ca565252f1fba2d4bffa68132

[kozy, 2017-02-06 19:48:00]

please take a look.

[jgruber, 2017-02-07 08:32:28]

lgtm, thanks for doing this.

https://codereview.chromium.org/2678143002/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2678143002/diff/1/src/api.cc#newcode9421
src/api.cc:9421: if (!obj->function()->shared()->script()->IsScript())
Nit: I think this'd be more readable if we store
obj->function()->shared()->script() in a maybe_script variable before the check
and subsequent cast (same below). Matter of taste though, so as you like.

[kozy, 2017-02-07 17:09:45]

thank you!

https://codereview.chromium.org/2678143002/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2678143002/diff/1/src/api.cc#newcode9421
src/api.cc:9421: if (!obj->function()->shared()->script()->IsScript())
On 2017/02/07 08:32:28, jgruber wrote:
> Nit: I think this'd be more readable if we store
> obj->function()->shared()->script() in a maybe_script variable before the
check
> and subsequent cast (same below). Matter of taste though, so as you like.

Done.

[kozy, 2017-02-07 17:09:52]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 17:09:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 17:37:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 17:37:26]

Dry run: This issue passed the CQ dry run.

[kozy, 2017-02-07 23:07:18]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-02-07 23:07:19]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2678143002/#ps20001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-02-07 23:07:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 23:09:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486508838967540,
"parent_rev": "e7b78ac22937f994d35376b38416a5844d6beced", "commit_rev":
"5870529de557db3ca565252f1fba2d4bffa68132"}

[commit-bot: I haz the power, 2017-02-07 23:09:08]

Description was changed from

==========
[inspector] introduced debug::GeneratorObject

- removed getGeneratorObjectLocation from debugger-script.js,
- one more step to remove all debugger context usages in inspector.

BUG=v8:5510
R=yangguo@chromium.org,jgruber@chromium.org,alph@chromium.org
==========

to

==========
[inspector] introduced debug::GeneratorObject

- removed getGeneratorObjectLocation from debugger-script.js,
- one more step to remove all debugger context usages in inspector.

BUG=v8:5510
R=yangguo@chromium.org,jgruber@chromium.org,alph@chromium.org

Review-Url: https://codereview.chromium.org/2678143002
Cr-Commit-Position: refs/heads/master@{#43018}
Committed:
https://chromium.googlesource.com/v8/v8/+/5870529de557db3ca565252f1fba2d4bffa...
==========

[commit-bot: I haz the power, 2017-02-07 23:09:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/5870529de557db3ca565252f1fba2d4bffa...