Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 267813002: Revert of Use texture-backed VideoFrame pipeline for Aura desktop capturing. (Closed)

Created:
6 years, 7 months ago by Lei Zhang
Modified:
6 years, 7 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Revert of Use texture-backed VideoFrame pipeline for Aura desktop capturing. (https://codereview.chromium.org/258663003/) Reason for revert: Likely cause of all Mac browser_tests failures [4296:71427:0501/193356:FATAL:video_util.cc(145)] Check failed: !(view_area.height() & 1). 0 libbase.dylib 0x698ac3ef base::debug::StackTrace::StackTrace() + 63 1 libbase.dylib 0x698ac44b base::debug::StackTrace::StackTrace() + 43 2 libbase.dylib 0x69951672 logging::LogMessage::~LogMessage() + 82 3 libbase.dylib 0x699500eb logging::LogMessage::~LogMessage() + 43 4 libmedia.dylib 0x67756110 media::LetterboxYUV(media::VideoFrame*, gfx::Rect const&) + 928 5 libmedia.dylib 0x6775773c media::CopyRGBToVideoFrame(unsigned char const*, int, gfx::Rect const&, media::VideoFrame*) + 492 6 libcontent.dylib 0x75f39814 content::(anonymous namespace)::RenderVideoFrame(SkBitmap const&, scoped_refptr\u003Cmedia::VideoFrame> const&, base::Callback\u003Cvoid ()(bool)> const&) + 2420 Original issue's description: > Use texture-backed VideoFrame pipeline for Aura desktop capturing. > > BUG=269312 > TEST=local build, run on CrOS snow > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267717 TBR=fischman@chromium.org,hshi@chromium.org NOTREECHECKS=true NOTRY=true BUG=269312 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267733

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -123 lines) Patch
M content/browser/media/capture/content_video_capture_device_core.h View 5 chunks +15 lines, -14 lines 0 comments Download
M content/browser/media/capture/content_video_capture_device_core.cc View 8 chunks +41 lines, -55 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura.cc View 7 chunks +5 lines, -44 lines 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device.cc View 5 chunks +15 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
Created Revert of Use texture-backed VideoFrame pipeline for Aura desktop capturing.
6 years, 7 months ago (2014-05-02 03:49:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/267813002/1
6 years, 7 months ago (2014-05-02 03:49:38 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 03:50:20 UTC) #3
Message was sent while issue was closed.
Change committed as 267733

Powered by Google App Engine
This is Rietveld 408576698