Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2678113002: Record UMA histogram when Form-Not-Secure warning is shown (Closed)

Created:
3 years, 10 months ago by estark
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Record UMA histogram when Form-Not-Secure warning is shown This records a histogram, at most once per main-frame navigation, when "Login not secure" is shown in a password form. This will allow us to measure the frequency of the warning (e.g. the number of times the warning is shown per million navigations.) BUG=687823 Review-Url: https://codereview.chromium.org/2670733002 Cr-Commit-Position: refs/heads/master@{#447960} (cherry picked from commit ce9ab459b6cce4f6d327b83ef49a8684a8839b9b) Review-Url: https://codereview.chromium.org/2678113002 . Cr-Commit-Position: refs/branch-heads/2987@{#340} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/15c16d7dd4f47fe47b20e4626fc05084cf533218

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -0 lines) Patch
M components/password_manager/core/browser/password_autofill_manager.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_autofill_manager.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_autofill_manager_unittest.cc View 2 chunks +44 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_manager_metrics_util.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_manager_metrics_util.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
estark
3 years, 10 months ago (2017-02-06 19:15:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
15c16d7dd4f47fe47b20e4626fc05084cf533218.

Powered by Google App Engine
This is Rietveld 408576698