Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issue 2678013002: Implemented the conversion logic from Wallet addresses to local Autofill profiles: (Closed)

Created:
3 years, 10 months ago by sebsg
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Implemented the conversion logic from Wallet addresses to local Autofill profiles: At each sync, looks for server addresses that have not been converted to local profiles yet. Then, for each of the non-converted Wallet addresses, look for a similar local profile to merge into. If one is found, merge into it following the existing merge logic. If none is found, add it as a new local Autofill profile. Also removed the assignation of an email address for Wallet addresses based on the user's account email, as it may have blocked some useful merges. BUG=680182 Review-Url: https://codereview.chromium.org/2658843004 Cr-Commit-Position: refs/heads/master@{#447859} (cherry picked from commit ed255a47bc7dddd9605ca08109fa396485984dc8) Review-Url: https://codereview.chromium.org/2678013002 . Cr-Commit-Position: refs/branch-heads/2987@{#325} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/85af9f1bc1d92dedf975aa565f5851b5365b79af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+607 lines, -260 lines) Patch
M components/autofill/core/browser/autofill_metrics.h View 2 chunks +13 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics_unittest.cc View 13 chunks +31 lines, -138 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.h View 4 chunks +32 lines, -5 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 8 chunks +100 lines, -32 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 4 chunks +386 lines, -55 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_table.cc View 4 chunks +21 lines, -16 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_table_unittest.cc View 2 chunks +2 lines, -14 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
sebsg
3 years, 10 months ago (2017-02-06 15:24:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
85af9f1bc1d92dedf975aa565f5851b5365b79af.

Powered by Google App Engine
This is Rietveld 408576698