net/quic/chromium/quic_stream_factory_test.cc - Issue 2678003003: Make QUIC force HOL-blocking mode only apply to v36. This is basically a no-op since neither v36 no…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/chromium/quic_stream_factory_test.cc

Issue 2678003003: Make QUIC force HOL-blocking mode only apply to v36. This is basically a no-op since neither v36 no… (Closed)

Patch Set: fix two chromium tests. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/chromium/quic_stream_factory_test.cc

diff --git a/net/quic/chromium/quic_stream_factory_test.cc b/net/quic/chromium/quic_stream_factory_test.cc

index e40a2bd2f7a6402dc1fc630f582114de44b0536a..4b9f10f6dc6b3573c3736132c881f3fd2a3567bf 100644

--- a/net/quic/chromium/quic_stream_factory_test.cc

+++ b/net/quic/chromium/quic_stream_factory_test.cc

@@ -5312,7 +5312,7 @@ TEST_P(QuicStreamFactoryTest, ForceHolBlockingEnabled) {

EXPECT_EQ(OK, callback_.WaitForResult());

QuicChromiumClientSession* session = GetActiveSession(host_port_pair_);

- if (session->connection()->version() > QUIC_VERSION_35) {

+ if (session->connection()->version() == QUIC_VERSION_36) {

EXPECT_TRUE(session->force_hol_blocking());

} else {

EXPECT_FALSE(session->force_hol_blocking());