Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: net/quic/chromium/quic_stream_factory_test.cc

Issue 2678003003: Make QUIC force HOL-blocking mode only apply to v36. This is basically a no-op since neither v36 no… (Closed)
Patch Set: fix two chromium tests. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/chromium/quic_stream_factory.h" 5 #include "net/quic/chromium/quic_stream_factory.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <ostream> 8 #include <ostream>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 5294 matching lines...) Expand 10 before | Expand all | Expand 10 after
5305 5305
5306 QuicStreamRequest request(factory_.get()); 5306 QuicStreamRequest request(factory_.get());
5307 EXPECT_EQ(ERR_IO_PENDING, 5307 EXPECT_EQ(ERR_IO_PENDING,
5308 request.Request(host_port_pair_, privacy_mode_, 5308 request.Request(host_port_pair_, privacy_mode_,
5309 /*cert_verify_flags=*/0, url_, "GET", net_log_, 5309 /*cert_verify_flags=*/0, url_, "GET", net_log_,
5310 callback_.callback())); 5310 callback_.callback()));
5311 5311
5312 EXPECT_EQ(OK, callback_.WaitForResult()); 5312 EXPECT_EQ(OK, callback_.WaitForResult());
5313 5313
5314 QuicChromiumClientSession* session = GetActiveSession(host_port_pair_); 5314 QuicChromiumClientSession* session = GetActiveSession(host_port_pair_);
5315 if (session->connection()->version() > QUIC_VERSION_35) { 5315 if (session->connection()->version() == QUIC_VERSION_36) {
5316 EXPECT_TRUE(session->force_hol_blocking()); 5316 EXPECT_TRUE(session->force_hol_blocking());
5317 } else { 5317 } else {
5318 EXPECT_FALSE(session->force_hol_blocking()); 5318 EXPECT_FALSE(session->force_hol_blocking());
5319 } 5319 }
5320 } 5320 }
5321 5321
5322 class QuicStreamFactoryWithDestinationTest 5322 class QuicStreamFactoryWithDestinationTest
5323 : public QuicStreamFactoryTestBase, 5323 : public QuicStreamFactoryTestBase,
5324 public ::testing::TestWithParam<PoolingTestParams> { 5324 public ::testing::TestWithParam<PoolingTestParams> {
5325 protected: 5325 protected:
(...skipping 359 matching lines...) Expand 10 before | Expand all | Expand 10 after
5685 // Clear all cached states. 5685 // Clear all cached states.
5686 factory_->ClearCachedStatesInCryptoConfig( 5686 factory_->ClearCachedStatesInCryptoConfig(
5687 base::Callback<bool(const GURL&)>()); 5687 base::Callback<bool(const GURL&)>());
5688 EXPECT_TRUE(test_cases[0].state->certs().empty()); 5688 EXPECT_TRUE(test_cases[0].state->certs().empty());
5689 EXPECT_TRUE(test_cases[1].state->certs().empty()); 5689 EXPECT_TRUE(test_cases[1].state->certs().empty());
5690 EXPECT_TRUE(test_cases[2].state->certs().empty()); 5690 EXPECT_TRUE(test_cases[2].state->certs().empty());
5691 } 5691 }
5692 5692
5693 } // namespace test 5693 } // namespace test
5694 } // namespace net 5694 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/chromium/quic_network_transaction_unittest.cc ('k') | net/quic/core/quic_session_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698