Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: components/image_fetcher/ios/ios_image_data_fetcher_wrapper.h

Issue 2677993002: Use IOSImageDataFetcherWrapper for favicon (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/image_fetcher/ios/ios_image_data_fetcher_wrapper.h
diff --git a/components/image_fetcher/ios/ios_image_data_fetcher_wrapper.h b/components/image_fetcher/ios/ios_image_data_fetcher_wrapper.h
index 81b5f70dbdfccfb4c9b31f2289a0bb31ca6eae3c..fa7a96aaaabf8625223cb076271edbf2ece85946 100644
--- a/components/image_fetcher/ios/ios_image_data_fetcher_wrapper.h
+++ b/components/image_fetcher/ios/ios_image_data_fetcher_wrapper.h
@@ -24,7 +24,8 @@ class GURL;
namespace image_fetcher {
// Callback that informs of the download of an image encoded in |data|.
gambard 2017/02/06 12:21:46 Update comment for response_code.
gambard 2017/02/06 15:58:28 Done.
-using IOSImageDataFetcherCallback = void (^)(NSData* data);
+using IOSImageDataFetcherCallback = void (^)(const int response_code,
+ NSData* data);
Marc Treib 2017/02/06 12:35:49 nit: data first, then response_code? To be consist
gambard 2017/02/06 15:58:28 Done.
class IOSImageDataFetcherWrapper {
public:

Powered by Google App Engine
This is Rietveld 408576698