Use IOSImageDataFetcherWrapper for favicon

components/image_fetcher/ios/ios_image_data_fetcher_wrapper.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_IMAGE_FETCHER_IOS_IOS_IMAGE_DATA_FETCHER_WRAPPER_H_
 #define COMPONENTS_IMAGE_FETCHER_IOS_IOS_IMAGE_DATA_FETCHER_WRAPPER_H_
 
 #import <Foundation/Foundation.h>
 
 #include "base/memory/ref_counted.h"
 #include "components/data_use_measurement/core/data_use_user_data.h"
 #include "components/image_fetcher/image_data_fetcher.h"
 
 namespace base {
 class TaskRunner;
 }
 
 namespace net {
 class URLRequestContextGetter;
 }
 
 class GURL;
 
 namespace image_fetcher {
 
 // Callback that informs of the download of an image encoded in |data|.

[gambard, 2017/02/06 12:21:46]

Update comment for response_code.

[gambard, 2017/02/06 15:58:28]

Done.

-using IOSImageDataFetcherCallback = void (^)(NSData* data);
+using IOSImageDataFetcherCallback = void (^)(const int response_code,
+                                             NSData* data);

[Marc Treib, 2017/02/06 12:35:49]

nit: data first, then response_code? To be consistent with the other callback
types.

[gambard, 2017/02/06 15:58:28]

Done.

 
 class IOSImageDataFetcherWrapper {
  public:
   using DataUseServiceName = data_use_measurement::DataUseUserData::ServiceName;
 
   // The TaskRunner is used to decode the image if it is WebP-encoded.
   IOSImageDataFetcherWrapper(
       net::URLRequestContextGetter* url_request_context_getter,
       const scoped_refptr<base::TaskRunner>& task_runner);
   virtual ~IOSImageDataFetcherWrapper();
@@ skipping 25 matching lines @@
   // The task runner used to decode images if necessary.
   const scoped_refptr<base::TaskRunner> task_runner_;
   ImageDataFetcher image_data_fetcher_;
 
   DISALLOW_COPY_AND_ASSIGN(IOSImageDataFetcherWrapper);
 };
 
 }  // namespace image_fetcher
 
 #endif  // COMPONENTS_IMAGE_FETCHER_IOS_IOS_IMAGE_DATA_FETCHER_WRAPPER_H_