Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2677983004: Make setOutputSurface, encrypted capabilities. Blacklist hi6210sft. (Closed)

Created:
3 years, 10 months ago by DaleCurtis
Modified:
3 years, 10 months ago
CC:
agrieve+watch_chromium.org, avayvod+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, mlamouri+watch-media_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make setOutputSurface, encrypted capabilities. Blacklist hi6210sft. No need for platform specific define for encrypted hardware decode support when we have a capability system; thus make support for encrypted streams a capability. We now have a device with broken MediaCodec.setOutputSurface(), so make it a capability and blacklist the hardware platform common to 99% of the crashes (hi6210sft). BUG=683401 TEST=p8lite no longer hangs on fullscreen transition. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2677983004 Cr-Commit-Position: refs/heads/master@{#448514} Committed: https://chromium.googlesource.com/chromium/src/+/8a5efb12a76b24de92a20a23f56d20aa9e22338b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -27 lines) Patch
M media/base/android/java/src/org/chromium/media/MediaCodecUtil.java View 1 chunk +12 lines, -0 lines 0 comments Download
M media/base/android/media_codec_util.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/base/android/media_codec_util.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M media/filters/gpu_video_decoder.cc View 4 chunks +15 lines, -19 lines 0 comments Download
M media/gpu/android_video_decode_accelerator.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M media/video/video_decode_accelerator.h View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
DaleCurtis
3 years, 10 months ago (2017-02-06 23:40:44 UTC) #4
sandersd (OOO until July 31)
lgtm
3 years, 10 months ago (2017-02-07 00:04:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677983004/20001
3 years, 10 months ago (2017-02-07 00:15:29 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 02:18:27 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8a5efb12a76b24de92a20a23f56d...

Powered by Google App Engine
This is Rietveld 408576698