Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Issue 2677943003: Fix and enable MTPDeviceDelegateImplWinTest.GalleryNameMTP. (Closed)

Created:
3 years, 10 months ago by fdoray
Modified:
3 years, 10 months ago
CC:
chromium-reviews, Lei Zhang, tommycli
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix and enable MTPDeviceDelegateImplWinTest.GalleryNameMTP. TestStorageMonitor must be destroyed after MediaFileSystemRegistry because MediaFileSystemRegistry uses it in its destructor. BUG=686803 Review-Url: https://codereview.chromium.org/2677943003 Cr-Commit-Position: refs/heads/master@{#448405} Committed: https://chromium.googlesource.com/chromium/src/+/99827662a4a6c77083b111a98b6e32797f9b5654

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/browser/media_galleries/win/mtp_device_delegate_impl_win_unittest.cc View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
fdoray
PTAL This previous CL https://codereview.chromium.org/2664073003/ was reverted because it deleted TestingBrowserProcess before ChromeRenderViewHostTestHarness::TearDown() which needed ...
3 years, 10 months ago (2017-02-06 19:46:28 UTC) #6
Reilly Grant (use Gerrit)
lgtm
3 years, 10 months ago (2017-02-06 21:47:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677943003/1
3 years, 10 months ago (2017-02-06 21:50:33 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 22:01:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/99827662a4a6c77083b111a98b6e...

Powered by Google App Engine
This is Rietveld 408576698