Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2677883002:
QUIC: Do not count the duplicate received bytes in GetTotalReceivedBytes (Closed)
|
Created:
3 years, 10 months ago by tbansal1 Modified:
3 years, 10 months ago Reviewers:
Ryan Hamilton CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionQUIC: Do not count the duplicate received bytes in GetTotalReceivedBytes
This CL changes QuicHttpStream::GetTotalReceivedBytes to not count
the duplicate received bytes. This ensures that GetTotalReceivedBytes
for QUIC maintains parity with other implementations of
GetTotalReceivedBytes that do not include duplicate bytes.
BUG=679123
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
Review-Url: https://codereview.chromium.org/2677883002
Cr-Commit-Position: refs/heads/master@{#448691}
Committed: https://chromium.googlesource.com/chromium/src/+/c097fbdf154063ede201dd70561fec8974eeb227
Patch Set 1 : ps #Patch Set 2 : use sequencer #
Messages
Total messages: 37 (31 generated)
Description was changed from ========== QUIC: Use non deuplicate data BUG= ========== to ========== QUIC: Use non deuplicate data BUG=679123 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ==========
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
Patchset #1 (id:20001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== QUIC: Use non deuplicate data BUG=679123 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ========== to ========== QUIC: Do not count the duplicate received bytes in GetTotalReceivedBytes This CL changes QuicHttpStream::GetTotalReceivedBytes to not count the duplicate received bytes. This ensures that GetTotalReceivedBytes for QUIC maintains parity with other implementations of GetTotalReceivedBytes that do not include duplicate bytes. BUG=679123 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ==========
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:40001) has been deleted
tbansal@chromium.org changed reviewers: + rch@chromium.org
rch: ptal. Thanks.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Most of this change is in shared QUIC code (the "core" directory). As such, it would be ideal to land an internal change for this first. Please ping me offline and I'll point you in the right direction.
Patchset #2 (id:80001) has been deleted
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
Patchset #2 (id:100001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
rch: ptal. Thanks for the comments.
lgtm
The CQ bit was checked by tbansal@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1486495077866350,
"parent_rev": "adb99b98e9271ed418fbc941852f5547b0d5d59c", "commit_rev":
"c097fbdf154063ede201dd70561fec8974eeb227"}
Message was sent while issue was closed.
Description was changed from ========== QUIC: Do not count the duplicate received bytes in GetTotalReceivedBytes This CL changes QuicHttpStream::GetTotalReceivedBytes to not count the duplicate received bytes. This ensures that GetTotalReceivedBytes for QUIC maintains parity with other implementations of GetTotalReceivedBytes that do not include duplicate bytes. BUG=679123 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ========== to ========== QUIC: Do not count the duplicate received bytes in GetTotalReceivedBytes This CL changes QuicHttpStream::GetTotalReceivedBytes to not count the duplicate received bytes. This ensures that GetTotalReceivedBytes for QUIC maintains parity with other implementations of GetTotalReceivedBytes that do not include duplicate bytes. BUG=679123 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2677883002 Cr-Commit-Position: refs/heads/master@{#448691} Committed: https://chromium.googlesource.com/chromium/src/+/c097fbdf154063ede201dd70561f... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:120001) as https://chromium.googlesource.com/chromium/src/+/c097fbdf154063ede201dd70561f... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
