Don't search for 'declaration' of elements, just name is usually enough.

Don't search for 'declaration' of elements, just name is usually enough.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/6e422fd0a7f295f5654447690b3557b4f1ae53d1

[Brian Wilkerson, 2017-02-05 19:20:13]

> ... just name is usually enough

When is the name not enough and what are the failure conditions (from the user's
perspective) when the name is not enough?

[scheglov, 2017-02-05 19:29:19]

On 2017/02/05 19:20:13, Brian Wilkerson wrote:
> > ... just name is usually enough
> 
> When is the name not enough and what are the failure conditions (from the
user's
> perspective) when the name is not enough?

Here "enough" means "we get enough information to implement features", not that
it may fail.
Basically it's a question of walking up AST - we can walk up declarations in
AstProvider, or we can do this in clients.
I think that in clients it is a bit better - we don't need to call generic
getAncestor(), we do less "is" type checks.

[Brian Wilkerson, 2017-02-05 19:55:22]

lgtm

[scheglov, 2017-02-05 20:21:10]

Description was changed from

==========
Don't search for 'declaration' of elements, just name is usually enough.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Don't search for 'declaration' of elements, just name is usually enough.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/6e422fd0a7f295f5654447690b3557b4f1ae53d1
==========

[scheglov, 2017-02-05 20:21:11]

Committed patchset #1 (id:1) manually as
6e422fd0a7f295f5654447690b3557b4f1ae53d1 (presubmit successful).