Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/convert_getter_to_method.dart

Issue 2677833002: Don't search for 'declaration' of elements, just name is usually enough. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/refactoring/convert_getter_to_method.dart
diff --git a/pkg/analysis_server/lib/src/services/refactoring/convert_getter_to_method.dart b/pkg/analysis_server/lib/src/services/refactoring/convert_getter_to_method.dart
index 5dd94166383e472e0a3c327aa5c3185b5f2e1b0c..0dac920f65c6f24ded500f9e392729e872890a83 100644
--- a/pkg/analysis_server/lib/src/services/refactoring/convert_getter_to_method.dart
+++ b/pkg/analysis_server/lib/src/services/refactoring/convert_getter_to_method.dart
@@ -91,11 +91,14 @@ class ConvertGetterToMethodRefactoringImpl extends RefactoringImpl
// prepare "get" keyword
Token getKeyword = null;
{
- AstNode node = await astProvider.getParsedNodeForElement(element);
- if (node is MethodDeclaration) {
- getKeyword = node.propertyKeyword;
- } else if (node is FunctionDeclaration) {
- getKeyword = node.propertyKeyword;
+ AstNode name = await astProvider.getParsedNameForElement(element);
+ AstNode declaration = name?.parent;
+ if (declaration is MethodDeclaration) {
+ getKeyword = declaration.propertyKeyword;
+ } else if (declaration is FunctionDeclaration) {
+ getKeyword = declaration.propertyKeyword;
+ } else {
+ return;
}
}
// remove "get "

Powered by Google App Engine
This is Rietveld 408576698