Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2677763002: Unskip mediastream-capture WPT tests (Closed)

Created:
3 years, 10 months ago by Rick Byers
Modified:
3 years, 10 months ago
Reviewers:
hta - Chromium
CC:
chromium-reviews, blink-reviews, posciak+watch_chromium.org, blink-reviews-w3ctests_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unskip mediastream-capture WPT tests Many of these are passing now. For those that aren't, add -expected.txt files so people notice when causing any new sub-test failures. Renamed MediaStreamTrack-end.https to be a manual test because it relies on user interaction to revoke the permission. Fixed timeout in MediaStream-MediaElement-preload-none.https.html by adding an error handler. Left MediaStreamTrack-MediaElement-disabled-audio-is-silence.https.html skipped due to time-out I couldn't figure out by the end of our WPT hackathon (tracked by http://crbug.com/688613). BUG=412381, 688613 Review-Url: https://codereview.chromium.org/2677763002 Cr-Commit-Position: refs/heads/master@{#452840} Committed: https://chromium.googlesource.com/chromium/src/+/747265bacb740e3f91170b6e271efcc72737c5b8

Patch Set 1 #

Patch Set 2 : Rebase and update manifest #

Patch Set 3 : Use correct manual test naming pattern #

Patch Set 4 : rebase, fix test name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -65 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 3 chunks +1 line, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json View 1 2 3 8 chunks +91 lines, -10 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/GUM-deny.https-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/GUM-empty-option-param.https-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/GUM-impossible-constraint.https-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/GUM-unknownkey-option-param.https-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaStream-MediaElement-preload-none.https.html View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaStream-MediaElement-preload-none.https-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaStream-MediaElement-srcObject.https-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaStreamTrack-MediaElement-disabled-audio-is-silence.https-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaStreamTrack-MediaElement-disabled-video-is-black.https-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaStreamTrack-end-manual.https.html View 3 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaStreamTrack-end.https.html View 1 chunk +0 lines, -39 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaStreamTrack-init.https-expected.txt View 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (16 generated)
Rick Byers
Hey Harald, We had a web-platform-test hackathon today and I worked to remove some 'Skipped' ...
3 years, 10 months ago (2017-02-04 01:49:55 UTC) #5
hta - Chromium
lgtm thanks for doing this! Where are we supposed to record the crbug numbers for ...
3 years, 10 months ago (2017-02-06 01:41:26 UTC) #8
foolip
On 2017/02/06 01:41:26, hta - Chromium wrote: > lgtm > > thanks for doing this! ...
3 years, 10 months ago (2017-02-06 02:20:51 UTC) #9
hta - Chromium
On 2017/02/06 02:20:51, foolip wrote: > On 2017/02/06 01:41:26, hta - Chromium wrote: > > ...
3 years, 10 months ago (2017-02-07 10:28:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677763002/20001
3 years, 10 months ago (2017-02-08 14:37:37 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/384155)
3 years, 10 months ago (2017-02-08 15:38:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677763002/40001
3 years, 10 months ago (2017-02-08 22:23:37 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/149934) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 10 months ago (2017-02-08 22:27:01 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677763002/50001
3 years, 10 months ago (2017-02-24 15:04:18 UTC) #23
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 16:22:04 UTC) #26
Message was sent while issue was closed.
Committed patchset #4 (id:50001) as
https://chromium.googlesource.com/chromium/src/+/747265bacb740e3f91170b6e271e...

Powered by Google App Engine
This is Rietveld 408576698