Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2677723002: Convert Oscillator tests to testharness (Closed)

Created:
3 years, 10 months ago by Raymond Toy
Modified:
3 years, 10 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Oscillator tests to testharness Manually convert test to use testharness. oscillator-basic.html was already using methods from old Audit, so I didn't change that. Just updated to testharness. oscillator-ended.html updated to testharness and new Audit. Expected result files removed. BUG=688414 TEST=oscillator-basic.html, oscillator-ended.html Review-Url: https://codereview.chromium.org/2677723002 Cr-Commit-Position: refs/heads/master@{#448702} Committed: https://chromium.googlesource.com/chromium/src/+/c3ffab1ea15cbd2c70c84cd785fd14e23052e332

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -62 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-basic.html View 3 chunks +2 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-basic-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-ended.html View 2 chunks +14 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-ended-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Raymond Toy
PTAL
3 years, 10 months ago (2017-02-07 17:02:54 UTC) #2
hongchan
lgtm
3 years, 10 months ago (2017-02-07 18:20:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677723002/1
3 years, 10 months ago (2017-02-07 18:25:00 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 19:47:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c3ffab1ea15cbd2c70c84cd785fd...

Powered by Google App Engine
This is Rietveld 408576698