Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2677713002: Add TEAM/COMPONENT (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 10 months ago
CC:
abarth-chromium, blink-reviews, chasej+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, extensions-reviews_chromium.org, haraken, iclelland+watch_chromuim.org, jam, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add TEAM/COMPONENT BUG=679905 Review-Url: https://codereview.chromium.org/2677713002 Cr-Commit-Position: refs/heads/master@{#448098} Committed: https://chromium.googlesource.com/chromium/src/+/9c3cf47241e4a45b0e8ec2a5ca8e487d028c4bb3

Patch Set 1 #

Total comments: 14

Patch Set 2 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M apps/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/updater/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M components/link_header_util/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/broadcast_channel/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/origin_trials/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/broadcastchannel/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tools/origin_trials/third_party/ed25519/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-03 18:53:48 UTC) #2
Marijn Kruisselbrink
https://codereview.chromium.org/2677713002/diff/1/apps/OWNERS File apps/OWNERS (right): https://codereview.chromium.org/2677713002/diff/1/apps/OWNERS#newcode10 apps/OWNERS:10: # COMPONENT: Platform>Apps TEAM: apps-dev@chromium.org https://codereview.chromium.org/2677713002/diff/1/chrome/browser/extensions/updater/OWNERS File chrome/browser/extensions/updater/OWNERS (right): ...
3 years, 10 months ago (2017-02-03 19:02:32 UTC) #3
ymzhang1
https://codereview.chromium.org/2677713002/diff/1/apps/OWNERS File apps/OWNERS (right): https://codereview.chromium.org/2677713002/diff/1/apps/OWNERS#newcode10 apps/OWNERS:10: # COMPONENT: Platform>Apps On 2017/02/03 19:02:31, Marijn Kruisselbrink wrote: ...
3 years, 10 months ago (2017-02-03 21:34:08 UTC) #4
Marijn Kruisselbrink
lgtm
3 years, 10 months ago (2017-02-03 21:36:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677713002/20001
3 years, 10 months ago (2017-02-03 21:39:57 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 22:47:56 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9c3cf47241e4a45b0e8ec2a5ca8e...

Powered by Google App Engine
This is Rietveld 408576698