Test reflecting on an object that implements Function but has no call method.

Test reflecting on an object that implements Function but has no call method.

BUG=http://dartbug.com/13957
R=asiva@google.com, gbracha@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29374

[gbracha, 2013-10-10 00:40:12]

lgtm

[ahe, 2013-10-10 14:33:51]

https://codereview.chromium.org/26777002/diff/1/tests/lib/mirrors/fake_functi...
File tests/lib/mirrors/fake_function_without_call_test.dart (right):

https://codereview.chromium.org/26777002/diff/1/tests/lib/mirrors/fake_functi...
tests/lib/mirrors/fake_function_without_call_test.dart:30: Expect.isFalse(im is
ClosureMirror);
I thought we had agreed that something that implements Function is a closure
mirror.

[rmacnak, 2013-10-10 16:24:00]

https://codereview.chromium.org/26777002/diff/1/tests/lib/mirrors/fake_functi...
File tests/lib/mirrors/fake_function_without_call_test.dart (right):

https://codereview.chromium.org/26777002/diff/1/tests/lib/mirrors/fake_functi...
tests/lib/mirrors/fake_function_without_call_test.dart:30: Expect.isFalse(im is
ClosureMirror);
On 2013/10/10 14:33:51, ahe wrote:
> I thought we had agreed that something that implements Function is a closure
> mirror.

Something that implements call. In this case, what would ClosureMirror.function
return?

[ahe, 2013-10-10 16:48:55]

https://codereview.chromium.org/26777002/diff/1/tests/lib/mirrors/fake_functi...
File tests/lib/mirrors/fake_function_without_call_test.dart (right):

https://codereview.chromium.org/26777002/diff/1/tests/lib/mirrors/fake_functi...
tests/lib/mirrors/fake_function_without_call_test.dart:30: Expect.isFalse(im is
ClosureMirror);
On 2013/10/10 16:24:00, Ryan Macnak wrote:
> On 2013/10/10 14:33:51, ahe wrote:
> > I thought we had agreed that something that implements Function is a closure
> > mirror.
> 
> Something that implements call. In this case, what would
ClosureMirror.function
> return?

I see the following options:

1. return null.
2. throw an exception.
3. what getField(#call) would do.

[gbracha, 2013-10-10 19:42:25]

On 2013/10/10 16:48:55, ahe wrote:
>
https://codereview.chromium.org/26777002/diff/1/tests/lib/mirrors/fake_functi...
> File tests/lib/mirrors/fake_function_without_call_test.dart (right):
> 
>
https://codereview.chromium.org/26777002/diff/1/tests/lib/mirrors/fake_functi...
> tests/lib/mirrors/fake_function_without_call_test.dart:30: Expect.isFalse(im
is
> ClosureMirror);
> On 2013/10/10 16:24:00, Ryan Macnak wrote:
> > On 2013/10/10 14:33:51, ahe wrote:
> > > I thought we had agreed that something that implements Function is a
closure
> > > mirror.
> > 
> > Something that implements call. In this case, what would
> ClosureMirror.function
> > return?
> 
> I see the following options:
> 
> 1. return null.
> 2. throw an exception.
> 3. what getField(#call) would do.

The current language spec & the spec for reflect() in mirrors.dart are in
agreement that membership in a function type is driven by defining a call()
method.  I'm not clear what the advantage of changing that is.

[ahe, 2013-10-11 12:56:05]

On 2013/10/10 19:42:25, gbracha wrote:
> On 2013/10/10 16:48:55, ahe wrote:
> >
>
https://codereview.chromium.org/26777002/diff/1/tests/lib/mirrors/fake_functi...
> > File tests/lib/mirrors/fake_function_without_call_test.dart (right):
> > 
> >
>
https://codereview.chromium.org/26777002/diff/1/tests/lib/mirrors/fake_functi...
> > tests/lib/mirrors/fake_function_without_call_test.dart:30: Expect.isFalse(im
> is
> > ClosureMirror);
> > On 2013/10/10 16:24:00, Ryan Macnak wrote:
> > > On 2013/10/10 14:33:51, ahe wrote:
> > > > I thought we had agreed that something that implements Function is a
> closure
> > > > mirror.
> > > 
> > > Something that implements call. In this case, what would
> > ClosureMirror.function
> > > return?
> > 
> > I see the following options:
> > 
> > 1. return null.
> > 2. throw an exception.
> > 3. what getField(#call) would do.
> 
> The current language spec & the spec for reflect() in mirrors.dart are in
> agreement that membership in a function type is driven by defining a call()
> method.  I'm not clear what the advantage of changing that is.

Simpler rules: if you have a call method, you implement Function. If you
implement Function, you're a closure.

[rmacnak, 2013-10-23 18:56:52]

Revised test to expect all objects whose class implements Function will be
reflected as closure mirrors.

https://codereview.chromium.org/26777002/diff/40001/tests/lib/mirrors/fake_fu...
File tests/lib/mirrors/fake_function_without_call_test.dart (right):

https://codereview.chromium.org/26777002/diff/40001/tests/lib/mirrors/fake_fu...
tests/lib/mirrors/fake_function_without_call_test.dart:36: Expect.isNull(mm);
Like cm.type.methods[#call]

[gbracha, 2013-10-23 19:04:51]

lgtm

[rmacnak, 2013-10-24 22:27:05]

Found mistake in test (passed extra argument to ClosureMirror.apply). 
DartEntry::InvokeClosure does in fact work when the object is neither a true
closure nor understands call.  Fixed remainder of ClosureMirror natives to work
with fake functions without call.

+Siva for runtime changes

[rmacnak, 2013-10-24 22:28:49]

Woops, actually add Siva

[siva, 2013-10-28 01:59:03]

lgtm

[rmacnak, 2013-10-28 17:25:57]

Committed patchset #5 manually as r29374 (presubmit successful).