Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1807)

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 26777002: Test reflecting on an object that implements Function but has no call method. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: rebase Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors_impl.dart
diff --git a/runtime/lib/mirrors_impl.dart b/runtime/lib/mirrors_impl.dart
index 5bb24acccdced14b2d61e445736d8d0772f708b4..cdcf3e35ddd2416bb4fb0e3f4d4c2d46af5cedb9 100644
--- a/runtime/lib/mirrors_impl.dart
+++ b/runtime/lib/mirrors_impl.dart
@@ -401,7 +401,7 @@ class _LocalClosureMirrorImpl extends _LocalInstanceMirrorImpl
InstanceMirror apply(List<Object> positionalArguments,
[Map<Symbol, Object> namedArguments]) {
- // TODO(iposva): When closures get an ordinary call method, this can be
+ // TODO(12602): When closures get an ordinary call method, this can be
// replaced with
// return this.invoke(#call, positionalArguments, namedArguments);
// and the native ClosureMirror_apply can be removed.
@@ -423,7 +423,7 @@ class _LocalClosureMirrorImpl extends _LocalInstanceMirrorImpl
// It is tempting to implement this in terms of Function.apply, but then
// lazy compilation errors would be fatal.
- return reflect(_apply(_reflectee, arguments, names));
+ return reflect(_apply(arguments, names));
}
Future<InstanceMirror> applyAsync(List positionalArguments,
@@ -448,7 +448,7 @@ class _LocalClosureMirrorImpl extends _LocalInstanceMirrorImpl
String toString() => "ClosureMirror on '${Error.safeToString(_reflectee)}'";
- static _apply(reflectee, arguments, argumentNames)
+ static _apply(arguments, argumentNames)
native 'ClosureMirror_apply';
static _computeFunction(reflectee)
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698