Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2677663004: Fix null heap profiler tag for allocations (Closed)

Created:
3 years, 10 months ago by ssid
Modified:
3 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix null heap profiler tag for allocations If the profiler tag is not set then the Connector should not pass null tag to the Watcher. BUG=676682 R=jcivelli@chromium.org,rockot@chromium.org Review-Url: https://codereview.chromium.org/2677663004 Cr-Commit-Position: refs/heads/master@{#448378} Committed: https://chromium.googlesource.com/chromium/src/+/dbaa71fb0ffc6eb3b122e98c69f1e63ff4f77639

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M mojo/public/cpp/bindings/lib/connector.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Jay Civelli
lgtm
3 years, 10 months ago (2017-02-06 17:45:58 UTC) #1
Ken Rockot(use gerrit already)
lgtm
3 years, 10 months ago (2017-02-06 17:47:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677663004/1
3 years, 10 months ago (2017-02-06 19:08:35 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 20:38:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dbaa71fb0ffc6eb3b122e98c69f1...

Powered by Google App Engine
This is Rietveld 408576698