Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2677653003: [ast] Minor cleanup in scopes.cc. (Closed)

Created:
3 years, 10 months ago by neis
Modified:
3 years, 10 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ast] Minor cleanup in scopes.cc. - Remove TODO concerning maybe-assigned. For LOOKUP variables, the flag doesn't really matter, so let's just set it to true to avoid confusion. - Simplify a condition. R=adamk@chromium.org BUG= Review-Url: https://codereview.chromium.org/2677653003 Cr-Commit-Position: refs/heads/master@{#42947} Committed: https://chromium.googlesource.com/v8/v8/+/fbd4cc9a369753c9470c895c879c9eaf32f4e815

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M src/ast/scopes.cc View 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
neis
3 years, 10 months ago (2017-02-03 10:18:18 UTC) #1
adamk
lgtm
3 years, 10 months ago (2017-02-04 00:05:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677653003/1
3 years, 10 months ago (2017-02-06 08:45:34 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 09:12:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/fbd4cc9a369753c9470c895c879c9eaf32f...

Powered by Google App Engine
This is Rietveld 408576698