Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2677643002: [Chromecast] Fix unit test failures due to underflow. (Closed)

Created:
3 years, 10 months ago by jameswest
Modified:
3 years, 10 months ago
Reviewers:
halliwell, kmackay
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Fix unit test failures due to underflow. - Return empty RenderingDelay from StreamMixerAlsaInputImpl when underflowing. - Fix expected value in MultizoneBackendTest after an underflow. BUG=internal b/34841900 Review-Url: https://codereview.chromium.org/2677643002 Cr-Commit-Position: refs/heads/master@{#447945} Committed: https://chromium.googlesource.com/chromium/src/+/f932aa80f326fba263e2f4e23ee886b97b89849a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chromecast/media/cma/backend/alsa/stream_mixer_alsa_input_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chromecast/media/cma/backend/multizone_backend_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
jameswest
3 years, 10 months ago (2017-02-03 03:56:05 UTC) #3
kmackay
lgtm
3 years, 10 months ago (2017-02-03 04:22:09 UTC) #4
halliwell
On 2017/02/03 04:22:09, kmackay wrote: > lgtm rs-lgtm
3 years, 10 months ago (2017-02-03 04:31:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677643002/1
3 years, 10 months ago (2017-02-03 04:43:00 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 04:57:06 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f932aa80f326fba263e2f4e23ee8...

Powered by Google App Engine
This is Rietveld 408576698