Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2677633002:
Upstream IndexedDB layout test to WPT. (Closed)
DescriptionUpstream IndexedDB layout test to WPT.
BUG=683463
Review-Url: https://codereview.chromium.org/2677633002
Cr-Commit-Position: refs/heads/master@{#448831}
Committed: https://chromium.googlesource.com/chromium/src/+/bbfebcb32ee6c94703fd319e7cf07b7090149471
Patch Set 1 : Moar consistency. #
Total comments: 4
Patch Set 2 : Addressed feedback. #
Messages
Total messages: 25 (18 generated)
The CQ bit was checked by pwnall@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by pwnall@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
pwnall@chromium.org changed reviewers: + jsbell@google.com
PTAL?
Description was changed from ========== Upstream IndexedDB layout test to WPT. BUG=683463 ========== to ========== Upstream IndexedDB layout test to WPT. BUG=683463 ==========
pwnall@chromium.org changed reviewers: + jsbell@chromium.org - jsbell@google.com
On 2017/02/03 03:34:31, pwnall wrote: > PTAL? Once again, with the correct account.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2677633002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/external/wpt/IndexedDB/key-conversion-exceptions.htm (right): https://codereview.chromium.org/2677633002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/external/wpt/IndexedDB/key-conversion-exceptions.htm:10: function indexeddb_upgrade_test(upgrade_callback, description) { How about indexeddb_upgrade_only_test ? Just "indexeddb_upgrade_test" makes it sound like we're testing upgrades with it, but that's not how it is used in this file. https://codereview.chromium.org/2677633002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/external/wpt/IndexedDB/key-conversion-exceptions.htm:64: test((t) => { nit: no () required around single argument (here and below)
lgtm other than the nits
The CQ bit was checked by pwnall@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thank you very much for the feedback! https://codereview.chromium.org/2677633002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/external/wpt/IndexedDB/key-conversion-exceptions.htm (right): https://codereview.chromium.org/2677633002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/external/wpt/IndexedDB/key-conversion-exceptions.htm:10: function indexeddb_upgrade_test(upgrade_callback, description) { On 2017/02/03 19:29:42, jsbell wrote: > How about indexeddb_upgrade_only_test ? > > Just "indexeddb_upgrade_test" makes it sound like we're testing upgrades with > it, but that's not how it is used in this file. Done. https://codereview.chromium.org/2677633002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/external/wpt/IndexedDB/key-conversion-exceptions.htm:64: test((t) => { On 2017/02/03 19:29:42, jsbell wrote: > nit: no () required around single argument (here and below) Done. Gah, I keep falling for this :( Thanks for your patience... I'll get it eventually!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by pwnall@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jsbell@chromium.org Link to the patchset: https://codereview.chromium.org/2677633002/#ps40001 (title: "Addressed feedback.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486516020884450,
"parent_rev": "78c9144a00abf91237afd62d3fadea59f78298e9", "commit_rev":
"bbfebcb32ee6c94703fd319e7cf07b7090149471"}
Message was sent while issue was closed.
Description was changed from ========== Upstream IndexedDB layout test to WPT. BUG=683463 ========== to ========== Upstream IndexedDB layout test to WPT. BUG=683463 Review-Url: https://codereview.chromium.org/2677633002 Cr-Commit-Position: refs/heads/master@{#448831} Committed: https://chromium.googlesource.com/chromium/src/+/bbfebcb32ee6c94703fd319e7cf0... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/bbfebcb32ee6c94703fd319e7cf0... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
