Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2677613005: Add TEAM/COMPONENT (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 10 months ago
CC:
abarth-chromium, arv+watch_chromium.org, blink-reviews, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, einbinder+watch-test-runner_chromium.org, extensions-reviews_chromium.org, gcasto+watchlist_chromium.org, haraken, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, net-reviews_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add TEAM/COMPONENT BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2677613005 Cr-Commit-Position: refs/heads/master@{#448681} Committed: https://chromium.googlesource.com/chromium/src/+/61bfd27852074dac34ab7b3225fcbf92d9b0689f

Patch Set 1 #

Total comments: 6

Patch Set 2 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/browser/extensions/api/browsing_data/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/cookies/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/password_manager_internals/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/password_manager_internals/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/password_manager/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/test/data/password_manager/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/test_runner/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-03 22:43:31 UTC) #3
vabr (Chromium)
Drive-by: *password_manager* LGTM Cheers, Vaclav
3 years, 10 months ago (2017-02-04 00:35:36 UTC) #4
ymzhang1
On 2017/02/04 00:35:36, vabr (OOO until late Feb) wrote: > Drive-by: *password_manager* LGTM > > ...
3 years, 10 months ago (2017-02-04 01:39:56 UTC) #5
jochen (gone - plz use gerrit)
https://codereview.chromium.org/2677613005/diff/1/components/test_runner/OWNERS File components/test_runner/OWNERS (right): https://codereview.chromium.org/2677613005/diff/1/components/test_runner/OWNERS#newcode9 components/test_runner/OWNERS:9: # COMPONENT: Test that'd be Label: Test>Layout https://codereview.chromium.org/2677613005/diff/1/net/cookies/OWNERS File ...
3 years, 10 months ago (2017-02-04 18:45:09 UTC) #7
ymzhang1
https://codereview.chromium.org/2677613005/diff/1/components/test_runner/OWNERS File components/test_runner/OWNERS (right): https://codereview.chromium.org/2677613005/diff/1/components/test_runner/OWNERS#newcode9 components/test_runner/OWNERS:9: # COMPONENT: Test On 2017/02/04 18:45:09, jochen wrote: > ...
3 years, 10 months ago (2017-02-06 17:41:47 UTC) #8
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-02-07 15:08:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677613005/20001
3 years, 10 months ago (2017-02-07 17:24:11 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 18:56:52 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/61bfd27852074dac34ab7b3225fc...

Powered by Google App Engine
This is Rietveld 408576698