Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issue 2677603002: Revert of Convert make_qualified_names and make_element_factory to use JSON5. (Closed)

Created:
3 years, 10 months ago by ktyliu
Modified:
3 years, 10 months ago
Reviewers:
tapted, nainar, sashab
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, krit, f(malita), fs, gyuyoung2, kinuko+watch, kouhei+svg_chromium.org, loading-reviews+parser_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert make_qualified_names and make_element_factory to use JSON5. (patchset #5 id:80001 of https://codereview.chromium.org/2645283006/ ) Reason for revert: Unexpected compile failure -- https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/32431 Original issue's description: > Convert make_qualified_names and make_element_factory to use JSON5. > > Convert make_qualified_names.py, make_element_factory.py, > make_element_type_helpers.py, and make_element_lookup_trie.py > to use JSON5 config format. > > Converted these config files accordingly: > Source/core/html/HTMLAttributeNames.in > Source/core/html/HTMLTagNames.in > Source/core/html/parser/MathMLAttributeNames.in > Source/core/html/parser/MathMLTagNames.in > Source/core/svg/SVGAttributeNames.in > Source/core/svg/SVGTagNames.in > Source/core/svg/xlinkattrs.in > Source/core/xml/xmlattrs.in > Source/core/xml/xmlnsattrs.in > > Note that these files are updated together because: > 1. make_element_factory.py depends on make_qualified_names.py > 2. HTMLTagNames.in is common input to the scripts make_element_factory, > make_element_type_helpers and make_element_lookup_trie > > Removed FIXME in make_element_type_helpers.py since that case > no longer occurs. > > Also fixed bug in json5_generator where parameters should not be > validated if default_parameters is not provided. > (caught when I had typo on default_parameters in the script) > > BUG=677884 > > Review-Url: https://codereview.chromium.org/2645283006 > Cr-Original-Commit-Position: refs/heads/master@{#447450} > Committed: https://chromium.googlesource.com/chromium/src/+/f5ca5654596eeda38c2a796bbbad299d92b7f008 > Review-Url: https://codereview.chromium.org/2645283006 > Cr-Commit-Position: refs/heads/master@{#447891} > Committed: https://chromium.googlesource.com/chromium/src/+/701ccf95a0ec04657b59ad240e28be4085fe033f TBR=nainar@chromium.org,sashab@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=677884 Review-Url: https://codereview.chromium.org/2677603002 Cr-Commit-Position: refs/heads/master@{#447896} Committed: https://chromium.googlesource.com/chromium/src/+/d50208a95a17148ec119745d20ceba483da71672

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+943 lines, -1361 lines) Patch
M third_party/WebKit/Source/build/scripts/json5_generator.py View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/make_element_factory.py View 4 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/make_element_lookup_trie.py View 3 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/make_element_type_helpers.py View 5 chunks +24 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/make_qualified_names.py View 3 chunks +29 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/scripts.gni View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 9 chunks +12 lines, -12 lines 0 comments Download
A third_party/WebKit/Source/core/html/HTMLAttributeNames.in View 1 chunk +348 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/core/html/HTMLAttributeNames.json5 View 1 chunk +0 lines, -354 lines 0 comments Download
A third_party/WebKit/Source/core/html/HTMLTagNames.in View 1 chunk +145 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/core/html/HTMLTagNames.json5 View 1 chunk +0 lines, -481 lines 0 comments Download
A third_party/WebKit/Source/core/html/parser/MathMLAttributeNames.in View 1 chunk +6 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/core/html/parser/MathMLAttributeNames.json5 View 1 chunk +0 lines, -12 lines 0 comments Download
A third_party/WebKit/Source/core/html/parser/MathMLTagNames.in View 1 chunk +12 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/core/html/parser/MathMLTagNames.json5 View 1 chunk +0 lines, -18 lines 0 comments Download
A third_party/WebKit/Source/core/svg/SVGAttributeNames.in View 1 chunk +243 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/core/svg/SVGAttributeNames.json5 View 1 chunk +0 lines, -249 lines 0 comments Download
A third_party/WebKit/Source/core/svg/SVGTagNames.in View 1 chunk +71 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/core/svg/SVGTagNames.json5 View 1 chunk +0 lines, -115 lines 0 comments Download
A third_party/WebKit/Source/core/svg/xlinkattrs.in View 1 chunk +11 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/core/svg/xlinkattrs.json5 View 1 chunk +0 lines, -17 lines 0 comments Download
A third_party/WebKit/Source/core/xml/xmlattrs.in View 1 chunk +6 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/core/xml/xmlattrs.json5 View 1 chunk +0 lines, -12 lines 0 comments Download
A third_party/WebKit/Source/core/xml/xmlnsattrs.in View 1 chunk +4 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/core/xml/xmlnsattrs.json5 View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
ktyliu
Created Revert of Convert make_qualified_names and make_element_factory to use JSON5.
3 years, 10 months ago (2017-02-03 00:29:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677603002/1
3 years, 10 months ago (2017-02-03 00:30:39 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-03 00:30:40 UTC) #5
ktyliu
On 2017/02/03 at 00:30:40, commit-bot wrote: > No L-G-T-M from a valid reviewer yet. > ...
3 years, 10 months ago (2017-02-03 02:06:09 UTC) #6
nainar
On 2017/02/03 at 02:06:09, ktyliu wrote: > On 2017/02/03 at 00:30:40, commit-bot wrote: > > ...
3 years, 10 months ago (2017-02-03 02:10:12 UTC) #7
tapted
lgtm lgtm + cq to revert
3 years, 10 months ago (2017-02-03 02:13:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677603002/1
3 years, 10 months ago (2017-02-03 02:13:55 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 02:16:28 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d50208a95a17148ec119745d20ce...

Powered by Google App Engine
This is Rietveld 408576698