Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2677563003: Remote Playback API: move tests that can be moved to WPT. (Closed)

Created:
3 years, 10 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 10 months ago
Reviewers:
tkent, whywhat, foolip
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remote Playback API: move tests that can be moved to WPT. The ones that can't be moved have been annotated. BUG=688228 R=foolip@chromium.org Review-Url: https://codereview.chromium.org/2677563003 Cr-Commit-Position: refs/heads/master@{#448968} Committed: https://chromium.googlesource.com/chromium/src/+/88711fc20c047c0a3eae2b35fc555e48b2c3fe1d

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase and all #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -222 lines) Patch
M third_party/WebKit/LayoutTests/W3CImportExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json View 1 2 18 chunks +81 lines, -40 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/remote-playback/README.md View 1 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/remote-playback/cancel-watch-availability.html View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/remote-playback/disable-remote-playback-cancel-watch-availability-throws.html View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/remote-playback/disable-remote-playback-prompt-throws.html View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/remote-playback/disable-remote-playback-watch-availability-throws.html View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/remote-playback/watch-availability-initial-callback.html View 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/remoteplayback/availability-callback-gc.html View 1 1 chunk +3 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/remoteplayback/cancel-watch-availability.html View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/remoteplayback/disable-remote-playback-cancel-watch-availability-throws.html View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/remoteplayback/disable-remote-playback-prompt-throws.html View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/remoteplayback/disable-remote-playback-watch-availability-throws.html View 1 chunk +0 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/remoteplayback/prompt-twice-throws.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/remoteplayback/watch-availability-initial-callback.html View 1 chunk +0 lines, -30 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/remoteplayback/watch-availability-throws-low-end-device.html View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (17 generated)
mlamouri (slow - plz ping)
3 years, 10 months ago (2017-02-03 02:50:52 UTC) #3
whywhat
lgtm
3 years, 10 months ago (2017-02-04 07:23:35 UTC) #7
foolip
LGTM. I took a quick look to see if there's anything that would obviously not ...
3 years, 10 months ago (2017-02-05 16:01:18 UTC) #8
mlamouri (slow - plz ping)
foolip@, can you PTAL at the import file?
3 years, 10 months ago (2017-02-07 21:23:05 UTC) #9
mlamouri (slow - plz ping)
https://codereview.chromium.org/2677563003/diff/1/third_party/WebKit/LayoutTests/media/remoteplayback/availability-callback-gc.html File third_party/WebKit/LayoutTests/media/remoteplayback/availability-callback-gc.html (right): https://codereview.chromium.org/2677563003/diff/1/third_party/WebKit/LayoutTests/media/remoteplayback/availability-callback-gc.html#newcode11 third_party/WebKit/LayoutTests/media/remoteplayback/availability-callback-gc.html:11: // WPT: thistest can't be moved to WPT because ...
3 years, 10 months ago (2017-02-07 21:23:33 UTC) #11
tkent
lgtm
3 years, 10 months ago (2017-02-07 23:22:27 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677563003/20001
3 years, 10 months ago (2017-02-08 10:41:10 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/359406)
3 years, 10 months ago (2017-02-08 10:47:53 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677563003/40001
3 years, 10 months ago (2017-02-08 11:43:49 UTC) #24
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 12:54:10 UTC) #27
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/88711fc20c047c0a3eae2b35fc55...

Powered by Google App Engine
This is Rietveld 408576698