Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2677543004: Add TEAM/COMPONENT (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 10 months ago
Reviewers:
bengr, eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, pkl (ping after 24h if needed), jam, net-reviews_chromium.org, haraken, blink-reviews, eroman, darin-cc_chromium.org, arv+watch_chromium.org, agrieve+watch_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org, abarth-chromium, bnc+watch_chromium.org, mmenke, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add TEAM/COMPONENT BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2677543004 Cr-Commit-Position: refs/heads/master@{#449717} Committed: https://chromium.googlesource.com/chromium/src/+/bc2345c988d08f7b711cefc73fd42223b116211e

Patch Set 1 : update #

Total comments: 17

Patch Set 2 : update compo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/net/qualityprovider/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/android/net/OWNERS View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/net/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/net_internals/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/profiler/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/net/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/mime_util/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/net_log/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/webcrypto/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/net/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/net/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/webui/net_export/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/crypto/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/vim/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-03 23:23:53 UTC) #3
eroman
+bengr for the question below. https://codereview.chromium.org/2677543004/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/net/qualityprovider/OWNERS File chrome/android/java/src/org/chromium/chrome/browser/net/qualityprovider/OWNERS (right): https://codereview.chromium.org/2677543004/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/net/qualityprovider/OWNERS#newcode15 chrome/android/java/src/org/chromium/chrome/browser/net/qualityprovider/OWNERS:15: # COMPONENT: Services>SignIn @bengr, ...
3 years, 10 months ago (2017-02-07 19:59:38 UTC) #7
bengr
https://codereview.chromium.org/2677543004/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/net/qualityprovider/OWNERS File chrome/android/java/src/org/chromium/chrome/browser/net/qualityprovider/OWNERS (right): https://codereview.chromium.org/2677543004/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/net/qualityprovider/OWNERS#newcode15 chrome/android/java/src/org/chromium/chrome/browser/net/qualityprovider/OWNERS:15: # COMPONENT: Services>SignIn On 2017/02/07 19:59:38, eroman (slow) wrote: ...
3 years, 10 months ago (2017-02-09 17:19:01 UTC) #8
bengr
On 2017/02/09 17:19:01, bengr wrote: > https://codereview.chromium.org/2677543004/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/net/qualityprovider/OWNERS > File > chrome/android/java/src/org/chromium/chrome/browser/net/qualityprovider/OWNERS > (right): > > ...
3 years, 10 months ago (2017-02-09 21:46:01 UTC) #9
ymzhang1
https://codereview.chromium.org/2677543004/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/net/qualityprovider/OWNERS File chrome/android/java/src/org/chromium/chrome/browser/net/qualityprovider/OWNERS (right): https://codereview.chromium.org/2677543004/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/net/qualityprovider/OWNERS#newcode15 chrome/android/java/src/org/chromium/chrome/browser/net/qualityprovider/OWNERS:15: # COMPONENT: Services>SignIn On 2017/02/09 17:19:01, bengr wrote: > ...
3 years, 10 months ago (2017-02-10 18:32:52 UTC) #10
eroman
lgtm
3 years, 10 months ago (2017-02-10 18:43:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677543004/60001
3 years, 10 months ago (2017-02-10 18:53:48 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 20:19:50 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/bc2345c988d08f7b711cefc73fd4...

Powered by Google App Engine
This is Rietveld 408576698