Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2677523002: [ObjC ARC] Converts ios/chrome/browser/ui/context_menu:unit_tests to ARC. (Closed)

Created:
3 years, 10 months ago by stkhapugin
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/context_menu:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2677523002 Cr-Commit-Position: refs/heads/master@{#448342} Committed: https://chromium.googlesource.com/chromium/src/+/7719f15c6e4eeaaf2ba20f74507ff6d0e6702a6c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -27 lines) Patch
M ios/chrome/browser/ui/context_menu/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/context_menu/context_menu_coordinator_unittest.mm View 7 chunks +27 lines, -27 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
stkhapugin
PTAL
3 years, 10 months ago (2017-02-03 12:53:07 UTC) #6
stkhapugin
PTAL
3 years, 10 months ago (2017-02-03 12:53:10 UTC) #7
marq (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-03 14:27:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677523002/1
3 years, 10 months ago (2017-02-06 17:49:39 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 19:18:59 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7719f15c6e4eeaaf2ba20f74507f...

Powered by Google App Engine
This is Rietveld 408576698