Emit edit tracking information from *all* rewriters.

Emit edit tracking information from *all* rewriters.

BUG=676588
Review-Url: https://codereview.chromium.org/2677483004
Cr-Commit-Position: refs/heads/master@{#448662}
Committed: https://chromium.googlesource.com/chromium/src/+/fa61e05cdf78815e1e8b18cb943ca77aa0fcda1b

[Łukasz Anforowicz, 2017-02-04 00:45:41]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2017-02-04 00:45:41]

dcheng@, could you PTAL?

[dcheng, 2017-02-04 00:48:39]

We don't need this for the rebase helper anymore. For crash and other things, I
think we just need names that could be functions, right?

[Łukasz Anforowicz, 2017-02-04 00:55:43]

On 2017/02/04 00:48:39, dcheng wrote:
> We don't need this for the rebase helper anymore.

Oh, ok.  I wasn't aware of that / I don't know how the rebase helper will work.

> For crash and other things, I think we just need names that could be
functions, right?

Yes, I think this is correct.

Still, capturing the overall information is probably desirable (just in case).

[dcheng, 2017-02-04 20:33:59]

On 2017/02/04 00:55:43, Łukasz Anforowicz wrote:
> On 2017/02/04 00:48:39, dcheng wrote:
> > We don't need this for the rebase helper anymore.
> 
> Oh, ok.  I wasn't aware of that / I don't know how the rebase helper will
work.
> 
> > For crash and other things, I think we just need names that could be
> functions, right?
> 
> Yes, I think this is correct.
> 
> Still, capturing the overall information is probably desirable (just in case).

I think we should only emit the ones we need, it's easy enough to add others
later. As you mentioned, the output files are already huge.

[Łukasz Anforowicz, 2017-02-06 23:10:17]

On 2017/02/04 20:33:59, dcheng wrote:
> On 2017/02/04 00:55:43, Łukasz Anforowicz wrote:
> > On 2017/02/04 00:48:39, dcheng wrote:
> > > We don't need this for the rebase helper anymore.
> > 
> > Oh, ok.  I wasn't aware of that / I don't know how the rebase helper will
> work.
> > 
> > > For crash and other things, I think we just need names that could be
> > functions, right?
> > 
> > Yes, I think this is correct.
> > 
> > Still, capturing the overall information is probably desirable (just in
case).
> 
> I think we should only emit the ones we need, it's easy enough to add others
> later. As you mentioned, the output files are already huge.

I've added two notes below, but take them with a grain of salt, because I am not
familiar with the plans around rebasing/merging helper and with the plan for
applying the rename to other things (like comments, crash, etc.).

Notes:

1. We might need other kinds of renames to automate renaming of identifiers
mentioned in comments (although I assume tweaking the comments is not
necessarily something to be done as part of the big renaming CL itself).

2. Generating a list of renames is always possible "later" (i.e. checking out
the pre-rename revision and rerunning the clang tool), but it seems
useful/efficient to just stash the list of renames from the original invocation
of the clang tool?

[dcheng, 2017-02-07 07:48:01]

*shrug*

LGTM, I'm not sure we'll ever use it as it stands, but I guess it can't hurt.

[Łukasz Anforowicz, 2017-02-07 17:39:08]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2017-02-07 17:39:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 17:48:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486489148509840,
"parent_rev": "f307f287d11e34cee8507cf7cd04102479aa809e", "commit_rev":
"fa61e05cdf78815e1e8b18cb943ca77aa0fcda1b"}

[commit-bot: I haz the power, 2017-02-07 17:49:28]

Description was changed from

==========
Emit edit tracking information from *all* rewriters.

BUG=676588
==========

to

==========
Emit edit tracking information from *all* rewriters.

BUG=676588

Review-Url: https://codereview.chromium.org/2677483004
Cr-Commit-Position: refs/heads/master@{#448662}
Committed:
https://chromium.googlesource.com/chromium/src/+/fa61e05cdf78815e1e8b18cb943c...
==========

[commit-bot: I haz the power, 2017-02-07 17:49:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fa61e05cdf78815e1e8b18cb943c...