Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 2677483002: [turbofan] Remove obsolete {Checkpoint} for property access. (Closed)

Created:
3 years, 10 months ago by Michael Starzinger
Modified:
3 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove obsolete {Checkpoint} for property access. By now the effect-control linearizer correctly determines the dominating checkpoint, even for cases that contain effect-flow. We can elide the temporary checkpoints during lowering of property loads and stores that involve a sequence of map-checks. R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2677483002 Cr-Commit-Position: refs/heads/master@{#42914} Committed: https://chromium.googlesource.com/v8/v8/+/d4a4297eeac62e737052debf0dabc260018e6c54

Patch Set 1 #

Patch Set 2 : One more checkpoint. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -18 lines) Patch
M src/compiler/js-native-context-specialization.cc View 1 4 chunks +6 lines, -18 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
Michael Starzinger
3 years, 10 months ago (2017-02-02 15:49:48 UTC) #9
Benedikt Meurer
Cool. LGTM!
3 years, 10 months ago (2017-02-02 17:56:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677483002/20001
3 years, 10 months ago (2017-02-03 08:56:05 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 08:57:50 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/d4a4297eeac62e737052debf0dabc260018...

Powered by Google App Engine
This is Rietveld 408576698