Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2677373002: [parser] Cleanup: remove unused parameters to DeclareFunction (Closed)

Created:
3 years, 10 months ago by Dan Ehrenberg
Modified:
3 years, 10 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Cleanup: remove unused parameters to DeclareFunction R=adamk Review-Url: https://codereview.chromium.org/2677373002 Cr-Commit-Position: refs/heads/master@{#42976} Committed: https://chromium.googlesource.com/v8/v8/+/a701fce85ee58cb30c68336529f05630cea8c40d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M src/parsing/parser.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/parsing/parser.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/parsing/parser-base.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/parsing/preparser.h View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Dan Ehrenberg
3 years, 10 months ago (2017-02-06 21:54:53 UTC) #7
Dan Ehrenberg
3 years, 10 months ago (2017-02-06 21:54:53 UTC) #8
adamk
lgtm
3 years, 10 months ago (2017-02-06 22:04:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677373002/1
3 years, 10 months ago (2017-02-06 22:27:34 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 22:29:17 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a701fce85ee58cb30c68336529f05630cea...

Powered by Google App Engine
This is Rietveld 408576698