Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2677353002: Use TaskScheduler instead of WorkerPool in lorgnette_manager_client.cc. (Closed)

Created:
3 years, 10 months ago by fdoray
Modified:
3 years, 10 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, oshima+watch_chromium.org, hashimoto+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TaskScheduler instead of WorkerPool in lorgnette_manager_client.cc. This CL replaces base::WorkerPool::GetTaskRunner() with base::CreateTaskRunnerWithTraits(). The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG=659191 Review-Url: https://codereview.chromium.org/2677353002 Cr-Commit-Position: refs/heads/master@{#448398} Committed: https://chromium.googlesource.com/chromium/src/+/6fb6b06069c3c3df224960a68ed84e33ee9e13b2

Patch Set 1 #

Patch Set 2 : remove unused variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M chromeos/dbus/lorgnette_manager_client.cc View 1 2 chunks +7 lines, -10 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
fdoray
PTAL
3 years, 10 months ago (2017-02-06 20:26:17 UTC) #4
stevenjb
lgtm
3 years, 10 months ago (2017-02-06 20:27:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677353002/1
3 years, 10 months ago (2017-02-06 20:29:29 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/276962)
3 years, 10 months ago (2017-02-06 20:41:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677353002/20001
3 years, 10 months ago (2017-02-06 20:53:15 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 21:36:28 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6fb6b06069c3c3df224960a68ed8...

Powered by Google App Engine
This is Rietveld 408576698