[ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:eg_tests to ARC.

[ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2677293002
Cr-Commit-Position: refs/heads/master@{#452451}
Committed: https://chromium.googlesource.com/chromium/src/+/c128dc4e5b8cca6204736217dd000655859afdfd

[stkhapugin, 2017-02-06 17:07:19]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 17:07:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stkhapugin, 2017-02-06 17:44:04]

stkhapugin@chromium.org changed reviewers:
+ noyau@chromium.org

[stkhapugin, 2017-02-06 17:44:04]

PTAL

[commit-bot: I haz the power, 2017-02-06 19:16:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 19:16:11]

Dry run: This issue passed the CQ dry run.

[noyau (Ping after 24h), 2017-02-17 10:10:23]

I don't understand the s/[self class]/ClassName/ change. This will change the
behavior for potential subclasses, is there an interaction with ARC that I'm
missing hire?

[stkhapugin, 2017-02-17 10:39:17]

On 2017/02/17 10:10:23, noyau wrote:
> I don't understand the s/[self class]/ClassName/ change. This will change the
> behavior for potential subclasses, is there an interaction with ARC that I'm
> missing hire?

First, that's a test, so I imagine it won't have any subclasses.
Second, the change is because some of these [self class] are in blocks, and so
they would need a __weak weakSelf just to [weakself class] or typed-out class
name, and the latter sounds better to me. The rest I've changed for consistency.

[stkhapugin, 2017-02-21 13:10:25]

ping

[noyau (Ping after 24h), 2017-02-22 12:11:48]

lgtm

[stkhapugin, 2017-02-23 09:50:06]

The CQ bit was checked by stkhapugin@chromium.org

[commit-bot: I haz the power, 2017-02-23 09:50:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 10:58:22]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487843406865480, "parent_rev":
"698af19e9bad67813349d7a89174d140d624075f", "commit_rev":
"c128dc4e5b8cca6204736217dd000655859afdfd"}

[commit-bot: I haz the power, 2017-02-23 10:58:59]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2677293002
Cr-Commit-Position: refs/heads/master@{#452451}
Committed:
https://chromium.googlesource.com/chromium/src/+/c128dc4e5b8cca6204736217dd00...
==========

[commit-bot: I haz the power, 2017-02-23 10:59:00]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c128dc4e5b8cca6204736217dd00...