Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2677183004: [LayoutNG] Fix accidentally removed "private:". (Closed)

Created:
3 years, 10 months ago by ikilpatrick
Modified:
3 years, 10 months ago
Reviewers:
cbiesinger, Gleb Lanbin
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Fix accidentally removed "private:". Was accidentally removed: https://codereview.chromium.org/2655783006 :) BUG=635619 TBR=glebl@chromium.org Review-Url: https://codereview.chromium.org/2677183004 Cr-Commit-Position: refs/heads/master@{#448400} Committed: https://chromium.googlesource.com/chromium/src/+/51c8aa394d7b69454cc942e03b0dcfadb5358280

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ikilpatrick
3 years, 10 months ago (2017-02-06 19:15:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677183004/1
3 years, 10 months ago (2017-02-06 19:15:39 UTC) #3
cbiesinger
lgtm
3 years, 10 months ago (2017-02-06 19:15:51 UTC) #4
Gleb Lanbin
lgtm
3 years, 10 months ago (2017-02-06 19:24:23 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 21:46:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/51c8aa394d7b69454cc942e03b0d...

Powered by Google App Engine
This is Rietveld 408576698