Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2677173002: [Blink>Media] Allow autoplay muted on Android by default (Closed)

Created:
3 years, 10 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 10 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, nessy, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Blink>Media] Allow autoplay muted on Android by default There was a mistake causing autoplay muted is shipped on Android but it will be disabled if the chromium embedder doesn't specify content setting for "AllowAutoplay" preference. This CL makes the AllowAutoplay preference true by default so that it is allowed by embedders (including AndroidWebView) unless they explicitly disable it. Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Q1cnzNI2GpI/AL_eyUNABgAJ BUG=689018 Review-Url: https://codereview.chromium.org/2677173002 Cr-Commit-Position: refs/heads/master@{#448423} Committed: https://chromium.googlesource.com/chromium/src/+/faaa2fd0a05f1622d9a8806da118d4f3b602e707

Patch Set 1 #

Patch Set 2 : fixed layout tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/test_runner/mock_content_settings_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (13 generated)
Zhiqiang Zhang (Slow)
3 years, 10 months ago (2017-02-06 12:44:02 UTC) #2
mlamouri (slow - plz ping)
I would rename the CL title to not be WebView specific but be about Blink ...
3 years, 10 months ago (2017-02-06 12:47:58 UTC) #3
mlamouri (slow - plz ping)
oh, and lgtm :)
3 years, 10 months ago (2017-02-06 12:48:04 UTC) #4
Zhiqiang Zhang (Slow)
On 2017/02/06 12:47:58, mlamouri wrote: > I would rename the CL title to not be ...
3 years, 10 months ago (2017-02-06 14:08:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677173002/1
3 years, 10 months ago (2017-02-06 14:08:54 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/376804)
3 years, 10 months ago (2017-02-06 15:34:45 UTC) #10
Zhiqiang Zhang (Slow)
+dpranke: mock_content_settings_client.cc
3 years, 10 months ago (2017-02-06 16:56:33 UTC) #14
Dirk Pranke
lgtm
3 years, 10 months ago (2017-02-06 20:54:30 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677173002/20001
3 years, 10 months ago (2017-02-06 22:41:23 UTC) #20
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 22:49:20 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/faaa2fd0a05f1622d9a8806da118...

Powered by Google App Engine
This is Rietveld 408576698