Issue 2677153003: Fix event dispatching offset problem in the client-lib in high-dpi mode. (conversion)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2677153003: Fix event dispatching offset problem in the client-lib in high-dpi mode. (conversion) (Closed)

Created:
3 years, 10 months ago by riajiang

Modified:
3 years, 10 months ago

Reviewers:

CC:
chromium-reviews, kalyank, sadrul

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix event dispatching offset problem in the client-lib in high-dpi mode. Convert event location from pixels to DIP before sending it to Window::ConvertPointToTarget (which uses DIP) to add offset to the event location; then set_transform_events to be false in WindowEventDispatcher to avoid converting to DIP again. BUG=687700

Patch Set 1 #

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -4 lines)			Patch
M	ui/aura/mus/window_tree_client.cc	View	2 chunks	+7 lines, -3 lines	0 comments	Download
M	ui/aura/window_event_dispatcher.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	ui/aura/window_event_dispatcher.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download

Dependent Patchsets:

Issue 2694443002 Patch 1

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

riajiang

3 years, 10 months ago (2017-02-06 17:01:35 UTC) #1

Description was changed from

==========
Fix event dispatching offset problem in the client-lib in high-dpi mode.

BUG=687700
==========

to

==========
Fix event dispatching offset problem in the client-lib in high-dpi mode.

Convert event location from pixels to DIP before sending it to 
Window::ConvertPointToTarget (which uses DIP) to add offset to the event
location; then set_transform_events to be false in WindowEventDispatcher
to avoid converting to DIP again.

BUG=687700
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages