Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Unified Diff: Source/core/html/HTMLInputElement.cpp

Issue 267713006: node.cloneNode() should clone the value of file upload elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: incorporated review comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLInputElement.cpp
diff --git a/Source/core/html/HTMLInputElement.cpp b/Source/core/html/HTMLInputElement.cpp
index 7952c58f83be743b8803e9610ed433ab59f45558..9530c54deab42def39613fbcc6b11f3cc9a1160d 100644
--- a/Source/core/html/HTMLInputElement.cpp
+++ b/Source/core/html/HTMLInputElement.cpp
@@ -909,6 +909,15 @@ void HTMLInputElement::copyNonAttributePropertiesFromElement(const Element& sour
setChecked(sourceElement.m_isChecked);
m_reflectsCheckedAttribute = sourceElement.m_reflectsCheckedAttribute;
m_isIndeterminate = sourceElement.m_isIndeterminate;
+ if (isFileUpload()) {
+ RefPtrWillBeRawPtr<FileList> fileList(FileList::create());
+ size_t size = sourceElement.files()->length();
Inactive 2014/05/07 13:28:00 nit: "unsigned" (this is what FileList::length() r
gnana 2014/05/07 14:22:37 Done.
+ for (size_t i = 0; i < size; i++) {
Inactive 2014/05/07 13:28:00 nit: ++i nit: Use unsigned
gnana 2014/05/07 14:22:37 Done.
+ File* file = sourceElement.files()->item(i);
Inactive 2014/05/07 13:28:00 HTMLInputElement::files() is not inlined so you mi
gnana 2014/05/07 14:22:37 Done.
+ fileList->append(File::createWithRelativePath(file->path(), file->webkitRelativePath()));
+ }
+ setFiles(fileList.release());
+ }
HTMLTextFormControlElement::copyNonAttributePropertiesFromElement(source);
@@ -1319,7 +1328,7 @@ KURL HTMLInputElement::src() const
return document().completeURL(fastGetAttribute(srcAttr));
}
-FileList* HTMLInputElement::files()
+FileList* HTMLInputElement::files() const
{
return m_inputType->files();
}

Powered by Google App Engine
This is Rietveld 408576698