node.cloneNode() should clone the value of file upload elements

Source/core/html/HTMLInputElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2012 Samsung Electronics. All rights reserved.
@@ skipping 891 matching lines @@
 }
 
 void HTMLInputElement::copyNonAttributePropertiesFromElement(const Element& source)
 {
     const HTMLInputElement& sourceElement = static_cast<const HTMLInputElement&>(source);
 
     m_valueIfDirty = sourceElement.m_valueIfDirty;
     setChecked(sourceElement.m_isChecked);
     m_reflectsCheckedAttribute = sourceElement.m_reflectsCheckedAttribute;
     m_isIndeterminate = sourceElement.m_isIndeterminate;
+    if (isFileUpload()) {
+        RefPtrWillBeRawPtr<FileList> fileList(FileList::create());
+        size_t size = sourceElement.files()->length();

[Inactive, 2014/05/07 13:28:00]

nit: "unsigned" (this is what FileList::length() returns.

[gnana, 2014/05/07 14:22:37]

Done.

+        for (size_t i = 0; i < size; i++) {

[Inactive, 2014/05/07 13:28:00]

nit: ++i
nit: Use unsigned

[gnana, 2014/05/07 14:22:37]

Done.

+            File* file = sourceElement.files()->item(i);

[Inactive, 2014/05/07 13:28:00]

HTMLInputElement::files() is not inlined so you might want to cache the
FileList* before the loop.

[gnana, 2014/05/07 14:22:37]

Done.

+            fileList->append(File::createWithRelativePath(file->path(), file->webkitRelativePath()));
+        }
+        setFiles(fileList.release());
+    }
 
     HTMLTextFormControlElement::copyNonAttributePropertiesFromElement(source);
 
     m_needsToUpdateViewValue = true;
     m_inputTypeView->updateView();
 }
 
 String HTMLInputElement::value() const
 {
     String value;
@@ skipping 390 matching lines @@
         exceptionState.throwDOMException(IndexSizeError, "The value provided is 0, which is an invalid size.");
     else
         setSize(size);
 }
 
 KURL HTMLInputElement::src() const
 {
     return document().completeURL(fastGetAttribute(srcAttr));
 }
 
-FileList* HTMLInputElement::files()
+FileList* HTMLInputElement::files() const
 {
     return m_inputType->files();
 }
 
 void HTMLInputElement::setFiles(PassRefPtrWillBeRawPtr<FileList> files)
 {
     m_inputType->setFiles(files);
 }
 
 bool HTMLInputElement::receiveDroppedFiles(const DragData* dragData)
@@ skipping 543 matching lines @@
 }
 
 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
 PassRefPtr<RenderStyle> HTMLInputElement::customStyleForRenderer()
 {
     return m_inputTypeView->customStyleForRenderer(originalStyleForRenderer());
 }
 #endif
 
 } // namespace