Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Issue 2677063002: Rename encrypted media browsertest enum to not use YES/NO. (Closed)

Created:
3 years, 10 months ago by Patti Lor
Modified:
3 years, 10 months ago
CC:
chromium-reviews, chfremer+watch_chromium.org, mcasas+watch+vc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename encrypted media browsertest enum to not use YES/NO. Avoid clashes with the YES/NO keywords in Objective-C. BUG=687822 Review-Url: https://codereview.chromium.org/2677063002 Cr-Commit-Position: refs/heads/master@{#448572} Committed: https://chromium.googlesource.com/chromium/src/+/58397dcb1baf7977349645311d2e9d8c6a593375

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M chrome/browser/media/encrypted_media_browsertest.cc View 8 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Patti Lor
Hi tommi@, PTAL. Thanks!
3 years, 10 months ago (2017-02-07 00:10:44 UTC) #6
tommi (sloooow) - chröme
lgtm
3 years, 10 months ago (2017-02-07 07:51:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677063002/1
3 years, 10 months ago (2017-02-07 07:52:14 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 08:43:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/58397dcb1baf7977349645311d2e...

Powered by Google App Engine
This is Rietveld 408576698