Convert ActiveTabPermissionGranter to use the new navigation callbacks.

Convert ActiveTabPermissionGranter to use the new navigation callbacks.

BUG=682002
Review-Url: https://codereview.chromium.org/2677053004
Cr-Commit-Position: refs/heads/master@{#448553}
Committed: https://chromium.googlesource.com/chromium/src/+/ca0cadf070a8e3dd09f3f24d6180467b2bc3297b

[jam, 2017-02-06 19:31:07]

Description was changed from

==========
Convert ActiveTabPermissionGranter to use the new navigation callbacks.

BUG=682002
==========

to

==========
Convert ActiveTabPermissionGranter to use the new navigation callbacks.

BUG=682002
==========

[jam, 2017-02-06 19:31:07]

jam@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[jam, 2017-02-06 20:05:20]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 20:05:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-02-06 20:39:38]

oops, looks like I missed this one earlier.

[commit-bot: I haz the power, 2017-02-06 20:50:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 20:50:43]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-02-07 02:42:47]

lgtm

https://codereview.chromium.org/2677053004/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/active_tab_permission_granter.cc (left):

https://codereview.chromium.org/2677053004/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/active_tab_permission_granter.cc:147:
DCHECK(details.is_main_frame);  // important: sub-frames don't get granted!
Nit: maybe preserve this comment?

[jam, 2017-02-07 04:17:03]

https://codereview.chromium.org/2677053004/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/active_tab_permission_granter.cc (left):

https://codereview.chromium.org/2677053004/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/active_tab_permission_granter.cc:147:
DCHECK(details.is_main_frame);  // important: sub-frames don't get granted!
On 2017/02/07 02:42:47, Devlin wrote:
> Nit: maybe preserve this comment?

Done.

[jam, 2017-02-07 04:17:52]

The CQ bit was checked by jam@chromium.org

[jam, 2017-02-07 04:17:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2677053004/#ps20001
(title: "add back comment")

[commit-bot: I haz the power, 2017-02-07 04:18:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 05:16:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486441072180330,
"parent_rev": "be97fdf1c59e0e5b69022a8d03918a6c8e3a2428", "commit_rev":
"ca0cadf070a8e3dd09f3f24d6180467b2bc3297b"}

[commit-bot: I haz the power, 2017-02-07 05:18:13]

Description was changed from

==========
Convert ActiveTabPermissionGranter to use the new navigation callbacks.

BUG=682002
==========

to

==========
Convert ActiveTabPermissionGranter to use the new navigation callbacks.

BUG=682002

Review-Url: https://codereview.chromium.org/2677053004
Cr-Commit-Position: refs/heads/master@{#448553}
Committed:
https://chromium.googlesource.com/chromium/src/+/ca0cadf070a8e3dd09f3f24d6180...
==========

[commit-bot: I haz the power, 2017-02-07 05:18:14]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ca0cadf070a8e3dd09f3f24d6180...