Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2677033003: headless: Add a small C++ example application (Closed)

Created:
3 years, 10 months ago by Sami
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Add a small C++ example application Headless Shell has grown to be a little too complex to serve as an introduction to the headless C++ API. This patch adds a simpler example which is hopefully easier to follow. The application navigates to a URL given on the command line, waits for it to load and prints the DOM. BUG=546953 R=altimin@chromium.org Review-Url: https://codereview.chromium.org/2677033003 . Cr-Commit-Position: refs/heads/master@{#450025} Committed: https://chromium.googlesource.com/chromium/src/+/354db138caff746a371c025aee80b830d23ee7d0

Patch Set 1 #

Patch Set 2 : outerHTML instead of innerHTML #

Total comments: 12

Patch Set 3 : Review comments #

Patch Set 4 : Rebased. Don't require command line to be initialized. #

Patch Set 5 : Don't touch command line (already fixed elsewhere) #

Patch Set 6 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -13 lines) Patch
M headless/BUILD.gn View 1 2 3 4 5 2 chunks +11 lines, -0 lines 0 comments Download
M headless/README.md View 2 chunks +14 lines, -8 lines 0 comments Download
A headless/app/headless_example.cc View 1 2 1 chunk +180 lines, -0 lines 0 comments Download
M headless/app/headless_shell.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M headless/app/headless_shell.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 34 (24 generated)
Sami
3 years, 10 months ago (2017-02-10 14:25:17 UTC) #11
altimin
https://codereview.chromium.org/2677033003/diff/20001/headless/app/headless_example.cc File headless/app/headless_example.cc (right): https://codereview.chromium.org/2677033003/diff/20001/headless/app/headless_example.cc#newcode43 headless/app/headless_example.cc:43: headless::HeadlessBrowser* browser_; UNOWNED? https://codereview.chromium.org/2677033003/diff/20001/headless/app/headless_example.cc#newcode45 headless/app/headless_example.cc:45: headless::HeadlessWebContents* web_contents_; UNOWNED? https://codereview.chromium.org/2677033003/diff/20001/headless/app/headless_example.cc#newcode53 ...
3 years, 10 months ago (2017-02-10 14:39:43 UTC) #12
alex clarke (OOO till 29th)
https://codereview.chromium.org/2677033003/diff/20001/headless/app/headless_example.cc File headless/app/headless_example.cc (right): https://codereview.chromium.org/2677033003/diff/20001/headless/app/headless_example.cc#newcode25 headless/app/headless_example.cc:25: class HeadlessExample : public headless::HeadlessWebContents::Observer, This should probably extend ...
3 years, 10 months ago (2017-02-10 14:46:47 UTC) #13
Sami
Thanks! https://codereview.chromium.org/2677033003/diff/20001/headless/app/headless_example.cc File headless/app/headless_example.cc (right): https://codereview.chromium.org/2677033003/diff/20001/headless/app/headless_example.cc#newcode25 headless/app/headless_example.cc:25: class HeadlessExample : public headless::HeadlessWebContents::Observer, On 2017/02/10 14:46:47, ...
3 years, 10 months ago (2017-02-10 16:25:26 UTC) #14
altimin
thanks, lgtm!
3 years, 10 months ago (2017-02-13 14:30:07 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677033003/80001
3 years, 10 months ago (2017-02-13 15:58:08 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/152224) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 10 months ago (2017-02-13 16:00:11 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677033003/100001
3 years, 10 months ago (2017-02-13 17:29:35 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/362866)
3 years, 10 months ago (2017-02-13 17:37:41 UTC) #32
Sami
3 years, 10 months ago (2017-02-13 18:37:12 UTC) #34
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as
354db138caff746a371c025aee80b830d23ee7d0.

Powered by Google App Engine
This is Rietveld 408576698