Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 2677023007: aura mus: Install a DefautlCaptureClient in the TestWM. (Closed)

Created:
3 years, 10 months ago by Elliot Glaysher
Modified:
3 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aura mus: Install a DefautlCaptureClient in the TestWM. The TestWM crashes when trying to synchronize capture changes from the client because it doesn't have a CaptureClient. After TestWM has crashed, it stays crashed while running the views_mus_interactive_ui_tests suite, which leads to secondary hangs and retries due to flakiness. This decreases a run of that test suite from over 400 seconds to 10 seconds. BUG=689197 Review-Url: https://codereview.chromium.org/2677023007 Cr-Commit-Position: refs/heads/master@{#448483} Committed: https://chromium.googlesource.com/chromium/src/+/0802870f9ed84e195d8788d5aca277d59dbc33e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M services/ui/test_wm/test_wm.cc View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Elliot Glaysher
There are additional crashes, but they get retried almost instantly and don't timeout the process.
3 years, 10 months ago (2017-02-07 00:42:14 UTC) #7
sky
LGTM
3 years, 10 months ago (2017-02-07 00:57:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677023007/1
3 years, 10 months ago (2017-02-07 00:59:59 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 01:08:32 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0802870f9ed84e195d8788d5aca2...

Powered by Google App Engine
This is Rietveld 408576698