Clean up IconNTP-related code

Clean up IconNTP-related code

The variation is unused since M48 and all experiments expired more than
a year ago, so let's remove the client-side logic and command-line
switches, for simplicity and testability.

BUG=601860
Review-Url: https://codereview.chromium.org/2677023003
Cr-Commit-Position: refs/heads/master@{#449244}
Committed: https://chromium.googlesource.com/chromium/src/+/5600e9dc845f282ae9282c19509a84459142926c

[mastiz, 2017-02-06 09:02:38]

The CQ bit was checked by mastiz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 09:02:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mastiz, 2017-02-06 09:04:15]

mastiz@chromium.org changed reviewers:
+ treib@chromium.org

[Marc Treib, 2017-02-06 09:19:51]

lgtm

https://codereview.chromium.org/2677023003/diff/1/chrome/browser/search/local...
File chrome/browser/search/local_ntp_source.cc (left):

https://codereview.chromium.org/2677023003/diff/1/chrome/browser/search/local...
chrome/browser/search/local_ntp_source.cc:91: // Returns whether icon NTP is
enabled by experiment.
https://codereview.chromium.org/2670123003/ :D

[commit-bot: I haz the power, 2017-02-06 09:49:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 09:49:54]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2017-02-06 10:36:23]

https://codereview.chromium.org/2677023003/diff/1/chrome/browser/search/local...
File chrome/browser/search/local_ntp_source.cc (left):

https://codereview.chromium.org/2677023003/diff/1/chrome/browser/search/local...
chrome/browser/search/local_ntp_source.cc:91: // Returns whether icon NTP is
enabled by experiment.
On 2017/02/06 09:19:51, Marc Treib wrote:
> https://codereview.chromium.org/2670123003/ :D

FYI: That CL should land Very Soon Now, so you'll probably have to rebase
(trivially).

[mastiz, 2017-02-06 10:46:04]

On 2017/02/06 10:36:23, Marc Treib wrote:
>
https://codereview.chromium.org/2677023003/diff/1/chrome/browser/search/local...
> File chrome/browser/search/local_ntp_source.cc (left):
> 
>
https://codereview.chromium.org/2677023003/diff/1/chrome/browser/search/local...
> chrome/browser/search/local_ntp_source.cc:91: // Returns whether icon NTP is
> enabled by experiment.
> On 2017/02/06 09:19:51, Marc Treib wrote:
> > https://codereview.chromium.org/2670123003/ :D
> 
> FYI: That CL should land Very Soon Now, so you'll probably have to rebase
> (trivially).

Ack.

[mastiz, 2017-02-06 10:51:40]

mastiz@chromium.org changed reviewers:
+ huangs@chromium.org, sky@chromium.org

[mastiz, 2017-02-06 10:51:40]

huangs@chromium.org: Please review changes in 
chrome/

sky@chromium.org: Please review changes in 
components/favicon/core
ui/base

[huangs, 2017-02-06 11:00:16]

The CL that you're undoing is http://crrev.com/1043753002/ . Please check
whether the #include's added in the CL are no longer needed, and remove if as
appropriate. Otherwise LGTM.

[sky, 2017-02-06 17:26:21]

https://codereview.chromium.org/2677023003/diff/1/components/favicon/core/fav...
File components/favicon/core/favicon_driver_impl.cc (right):

https://codereview.chromium.org/2677023003/diff/1/components/favicon/core/fav...
components/favicon/core/favicon_driver_impl.cc:9: #include
"base/metrics/field_trial.h"
Remove any stale includes.

[mastiz, 2017-02-07 08:21:29]

On 2017/02/06 17:26:21, sky wrote:
>
https://codereview.chromium.org/2677023003/diff/1/components/favicon/core/fav...
> File components/favicon/core/favicon_driver_impl.cc (right):
> 
>
https://codereview.chromium.org/2677023003/diff/1/components/favicon/core/fav...
> components/favicon/core/favicon_driver_impl.cc:9: #include
> "base/metrics/field_trial.h"
> Remove any stale includes.

Done, PTAL.

[sky, 2017-02-07 15:56:16]

LGTM

[Marc Treib, 2017-02-07 16:21:22]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 16:21:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 17:20:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 17:20:55]

Dry run: This issue passed the CQ dry run.

[mastiz, 2017-02-08 11:03:44]

The CQ bit was checked by mastiz@chromium.org

[mastiz, 2017-02-08 11:03:47]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org,
huangs@chromium.org
Link to the patchset: https://codereview.chromium.org/2677023003/#ps20001
(title: "Remove unnecessary includes.")

[mastiz, 2017-02-08 11:03:47]

The CQ bit was unchecked by mastiz@chromium.org

[mastiz, 2017-02-08 11:09:03]

mastiz@chromium.org changed reviewers:
+ asvitkine@chromium.org

[mastiz, 2017-02-08 11:09:04]

asvitkine@chromium.org: Please review changes in 

content/browser/renderer_host/render_process_host_impl.cc	testing/variations/fieldtrial_testing_config.json

[Alexei Svitkine (slow), 2017-02-08 16:29:41]

lgtm

[mastiz, 2017-02-09 08:16:00]

The CQ bit was checked by mastiz@chromium.org

[mastiz, 2017-02-09 08:16:01]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org,
huangs@chromium.org
Link to the patchset: https://codereview.chromium.org/2677023003/#ps20001
(title: "Remove unnecessary includes.")

[commit-bot: I haz the power, 2017-02-09 08:16:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 09:16:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486628160354230,
"parent_rev": "0618218ad2514070703af6237b0ae3579276b433", "commit_rev":
"5600e9dc845f282ae9282c19509a84459142926c"}

[commit-bot: I haz the power, 2017-02-09 09:17:19]

Description was changed from

==========
Clean up IconNTP-related code

The variation is unused since M48 and all experiments expired more than
a year ago, so let's remove the client-side logic and command-line
switches, for simplicity and testability.

BUG=601860
==========

to

==========
Clean up IconNTP-related code

The variation is unused since M48 and all experiments expired more than
a year ago, so let's remove the client-side logic and command-line
switches, for simplicity and testability.

BUG=601860

Review-Url: https://codereview.chromium.org/2677023003
Cr-Commit-Position: refs/heads/master@{#449244}
Committed:
https://chromium.googlesource.com/chromium/src/+/5600e9dc845f282ae9282c19509a...
==========

[commit-bot: I haz the power, 2017-02-09 09:17:20]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5600e9dc845f282ae9282c19509a...