SearchIPCRouter: Invalidate cached connection ID on renderer crash

SearchIPCRouter: Invalidate cached connection ID on renderer crash

BUG=683021
Review-Url: https://codereview.chromium.org/2677013004
Cr-Commit-Position: refs/heads/master@{#448519}
Committed: https://chromium.googlesource.com/chromium/src/+/3c36d59b4bd011c2bbbf28d59275aa082ede1ff5

[tibell, 2017-02-07 00:29:57]

The CQ bit was checked by tibell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 00:31:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tibell, 2017-02-07 00:34:58]

tibell@chromium.org changed reviewers:
+ sammc@chromium.org, treib@chromium.org

[tibell, 2017-02-07 00:34:59]

This fixes the issue in M-57. I think a longer term better way to handle this is
to not have this two way connection and instead just have the frame connect to
the WebContentsObserver and pass it a pipe it can use to talk back to the frame.
This would remove all this business with remembering frame IDs in the WCO.

[Sam McNally, 2017-02-07 00:38:33]

lgtm

[tibell, 2017-02-07 00:42:38]

tibell@chromium.org changed reviewers:
+ jam@chromium.org

[tibell, 2017-02-07 00:42:39]

jam: I need some top-level approval for this M-57 bug fix.

(As an aside, as my initial email on this CL says, I think this logic is very
brittle and should be changed, but that will have to be after M-57.)

[commit-bot: I haz the power, 2017-02-07 01:25:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 01:25:29]

Dry run: This issue passed the CQ dry run.

[jam, 2017-02-07 01:28:36]

lgtm

[tibell, 2017-02-07 01:49:34]

The CQ bit was checked by tibell@chromium.org

[commit-bot: I haz the power, 2017-02-07 01:50:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 02:30:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486432174146170, "parent_rev":
"c5c5a6386f74ad73d8b0e3e567a08d3ea664d78c", "commit_rev":
"3c36d59b4bd011c2bbbf28d59275aa082ede1ff5"}

[commit-bot: I haz the power, 2017-02-07 02:31:37]

Description was changed from

==========
SearchIPCRouter: Invalidate cached connection ID on renderer crash

BUG=683021
==========

to

==========
SearchIPCRouter: Invalidate cached connection ID on renderer crash

BUG=683021

Review-Url: https://codereview.chromium.org/2677013004
Cr-Commit-Position: refs/heads/master@{#448519}
Committed:
https://chromium.googlesource.com/chromium/src/+/3c36d59b4bd011c2bbbf28d59275...
==========

[commit-bot: I haz the power, 2017-02-07 02:31:38]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3c36d59b4bd011c2bbbf28d59275...

[Marc Treib, 2017-02-07 08:58:26]

LGTM, thanks!